Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jul 9, 2025

Goal is to make the indexing more obvious. Also updated to use Lucide more consistently.

Before:
Screenshot 2025-07-09 at 2 31 23 PM

After:
Screenshot 2025-07-09 at 2 31 46 PM


Important

Update ChatTextArea and IndexingStatusBadge to use Lucide icons and improve indexing status display.

  • Icons:
    • Replaced IconButton with button elements using Lucide icons WandSparkles, SendHorizontal, and Image in ChatTextArea.tsx.
    • Updated IndexingStatusBadge.tsx to use Database icon from Lucide.
  • Components:
    • Renamed IndexingStatusDot to IndexingStatusBadge in IndexingStatusBadge.tsx and ChatTextArea.tsx.
  • Tests:
    • Updated ChatTextArea.spec.tsx to check for Lucide icons and updated button behavior.
    • Updated IndexingStatusBadge.spec.tsx to reflect changes in IndexingStatusBadge component.

This description was created by Ellipsis for e4c6701. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners July 9, 2025 18:31
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused labels Jul 9, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jul 9, 2025

No security or compliance issues detected. Reviewed everything up to e4c6701.

Security Overview
  • 🔎 Scanned files: 4 changed file(s)
Detected Code Changes
Change Type Relevant files
Bug Fix ► ChatTextArea.tsx
    Revert image icon alignment with gap-0.5 and mr-1
► IndexingStatusBadge.tsx
    Update component styling and structure
tests/ChatTextArea.spec.tsx
    Update tests for icon changes
tests/IndexingStatusBadge.spec.tsx
    Update component name and tests

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 9, 2025
- Changed Camera icon to Image icon from lucide-react
- Fixed alignment issue by adjusting gap and removing extra margin
- Updated tests to work with new Lucide icon structure
- Keep original alignment with gap-0.5 and mr-1 to match send and enhance buttons
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jul 9, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 9, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 9, 2025
@mrubens mrubens merged commit 2b7c266 into main Jul 9, 2025
16 checks passed
@mrubens mrubens deleted the chat_text_area_icon_updates branch July 9, 2025 19:03
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jul 9, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants