feat: Replace image-only attachment with general file attachment support (#5532) #5533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 9, 2025 22:25
…ort (RooCodeInc#5532) - Replace camera icon with paperclip icon in ChatTextArea component - Add comprehensive file attachment support via new process-files.ts - Support all file types with intelligent MIME type detection - Maintain backward compatibility with existing image functionality - Add translations for 'attachFiles' in all supported languages (en, fr, ko, tr, ru) - Update message types to support both selectImages and selectFiles workflows - Add file size validation (10MB limit) and proper error handling - Support text files (displayed as content) and binary files (base64 encoded) This enhancement expands the current image-only attachment system to support all file types while preserving existing functionality and user workflows.
dosubot
bot
added
the
size:L
Closed
4 tasks
dosubot
bot
added
enhancement
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| fileUris.map(async (uri) => { | ||
| const filePath = uri.fsPath | ||
| const fileName = path.basename(filePath) | ||
| const stats = await fs.stat(filePath) |
Contributor
There was a problem hiding this comment.
Consider wrapping file operations (fs.stat and fs.readFile) in try/catch blocks to handle potential errors (e.g. permission issues or file removal) gracefully.
hannesrudolph
added
the
Issue/PR - Triage
Member
|
Automatically closed: PR created by @roomote-agent before 2025-07-16 |
github-project-automation
bot
moved this from Roomote/renovate BOT
to Done
in Roo Code Roadmap
Contributor
|
I see this PR was automatically closed. I'm reviewing the file attachment feature implementation and will assess what needs to be completed. Let me check the current state of the code and provide an update. |
Contributor
✅ Implementation CompleteI have successfully implemented the general file attachment feature to replace the image-only attachment system. Here is a comprehensive summary of what was accomplished: 🚀 New Pull Request Created🎯 Key Features Implemented📎 UI Changes
🔧 Comprehensive File Processing System
🛡️ Smart Content Handling
🌐 Internationalization
🔄 Backward Compatibility
🏗️ Technical ImplementationMessage System Updates
Frontend Components
File Processing Architecture
🧪 Quality Assurance
📋 Files Modified
🔍 Current Status
The implementation successfully addresses all requirements from issue #5532 while maintaining full backward compatibility and providing a robust foundation for future file handling enhancements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5532
This PR expands the current image-only attachment system to support all file types while maintaining full backward compatibility. The enhancement replaces the camera icon with a paperclip icon to better reflect the general file attachment functionality.
Changes Made
UI Updates
Backend Enhancements
Message System Updates
Internationalization
Backward Compatibility
Technical Implementation
File Type Support
The new system supports comprehensive file categories:
Testing Performed
Verification of Acceptance Criteria
Files Changed
Potential Impacts
The implementation maintains the existing codebase patterns while providing a robust, extensible file attachment system.
Important
Expands attachment system to support all file types with UI, backend, and internationalization updates, maintaining backward compatibility with image-only attachments.
ChatTextArea.tsxandChatView.tsx.ChatTextArea.tsx.process-files.tsfor handling all file types with MIME type detection and size validation.WebviewMessageand "selectedFiles" toExtensionMessage.webviewMessageHandler.tsto handle new message types.ChatTextArea.spec.tsxto cover new file attachment functionality.This description was created by
for a0633ad. You can customize this summary. It will automatically update as commits are pushed.