feat: Implement task history scanner and recovery tools #5546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XXL
Contributor
|
Generated with ❤️ by ellipsis.dev |
This was referenced Jul 10, 2025
hannesrudolph
added
the
Issue/PR - Triage
KJ7LNW
force-pushed
the
refactor-use-files-for-history-scanner
branch
3 times, most recently
from
27e4576 to
4f14c1e
Compare
Contributor
|
Generated with ❤️ by ellipsis.dev |
KJ7LNW
force-pushed
the
refactor-use-files-for-history-scanner
branch
from
4f14c1e to
cfc86e7
Compare
hannesrudolph
added
PR - Draft / In Progress
and removed
Issue/PR - Triage
hannesrudolph
moved this from PR [Draft / In Progress]
to PR [Needs Prelim Review]
in Roo Code Roadmap
hannesrudolph
added
PR - Needs Preliminary Review
and removed
PR - Draft / In Progress
labels
Member
|
Hey @KJ7LNW,Thanks for the work on this! Do you think we should consider simplifying the UI and options a bit? Maybe a single button to restore tasks under the "About Roo Code" section or somewhere similar that just restores tasks for the current workspace? I’m a bit concerned that the current options might be too complex for users who are just trying to recover lost tasks quickly. Let me know what you think. |
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Changes Requested]
in Roo Code Roadmap
added 18 commits
July 11, 2025 15:06
- Move fuzzy search from frontend to backend using fzf library - Create dedicated taskHistorySearch module with configurable parameters - Add match position tracking for proper highlighting in UI - Implement debounced search in frontend to prevent flickering Signed-off-by: Eric Wheeler <[email protected]> fix: maintain sort order during search When a search string is present, the sort order specified by the user wasn't being respected. This change ensures that: - Non-relevance sorts (newest, oldest, etc.) maintain their order when searching - The 'mostRelevant' sort option continues to use fuzzy search order Signed-off-by: Eric Wheeler <[email protected]>
Implemented automatic refresh of the task history list when tasks are deleted: - Added taskDeletedConfirmation message type to WebviewMessage and ExtensionMessage - Modified webviewMessageHandler to send confirmation after task deletion - Updated useTaskSearch hook to listen for deletion confirmation and refresh the list - Implemented non-flickering refresh that maintains current search parameters Signed-off-by: Eric Wheeler <[email protected]>
- Created SpinnerOverlay component to darken the view during deletion - Added state to track deletion in progress in HistoryView - Updated DeleteTaskDialog and BatchDeleteTaskDialog to trigger the overlay - Added event listener to hide the overlay when deletion completes Signed-off-by: Eric Wheeler <[email protected]>
Add request ID tracking to useTaskSearch hook to ensure each component only processes responses to its own search requests. This prevents the issue where multiple components using the hook would all receive updates when a search response comes back, regardless of which component initiated the search. - Add global serial counter to generate unique request IDs - Add component-isolated ref to track current request ID - Modify message handler to only process matching responses - Pass request ID back in webviewMessageHandler response Signed-off-by: Eric Wheeler <[email protected]>
Removed taskHistory field and all its references from the codebase as part of migrating to file-based storage. - Removed taskHistory from GlobalSettings schema - Removed import of historyItemSchema - Removed taskHistory from ExtensionState interface - Cleared PASS_THROUGH_STATE_KEYS array in ContextProxy - Updated ClineProvider to use file-based API instead of global state - Updated UI components to work without taskHistory prop Signed-off-by: Eric Wheeler <[email protected]>
Removed redundant useTaskSearch call from ChatView since HistoryPreview already makes its own call to fetch the tasks it needs to display. This eliminates an unnecessary API call on application startup and simplifies the component by removing conditional rendering based on task count. Signed-off-by: Eric Wheeler <[email protected]>
Remove unnecessary loading and returning of entire task history array. The return value was never used by any caller, so we can make this an O(1) operation instead of O(n) by simply saving the single item. This change significantly improves performance when updating task history, which happens frequently during task execution. Signed-off-by: Eric Wheeler <[email protected]>
Allows you to filter tasks not just by all and current, but also by any
historic workspace directory that exists in existing HistoryItem metadata
- Added persistent workspace index with metadata (path, name, missing status, timestamp)
- Created a rich workspace selector UI with filtering and grouping capabilities
- Added visual indicators for missing workspaces (strikethrough)
- Improved loading states and feedback during workspace changes and searches
- Added special workspace paths handling ("all", "current", "unknown")
- Standardized empty/undefined workspace paths to "unknown" for legacy items that do not have workspace stored in their metadata
- Optimized batch processing for better performance
This enhancement provides users with a more intuitive and powerful way to navigate their task history across multiple workspaces.
Signed-off-by: Eric Wheeler <[email protected]>
Added a limit filter dropdown to the history view that allows users to control how many results are displayed. The filter: - Defaults to 50 items - Offers options for 50, 100, 200, 500, 1000 items or all results - Shows loading spinner when changing limits - Integrates with existing workspace and sort filters - Maintains consistent search options across operations Signed-off-by: Eric Wheeler <[email protected]>
This change modifies the copy button in task history to retrieve the task content from the backend storage using getHistoryItem before copying it to the clipboard. This ensures the most up-to-date content is copied. Fixes: #3648 Signed-off-by: Eric Wheeler <[email protected]>
Implement a structured upgrade system that manages the task history migration process: - Create a dedicated upgrade UI that blocks normal app usage until migration completes - Separate migration check from migration execution for better control flow - Add progress logging during migration to provide user feedback - Remove automatic migration during extension activation - Add new message types for upgrade status and completion This change improves the user experience during task history migration by providing visual feedback and ensuring the app is in a consistent state before allowing normal usage. The upgrade system is designed to be extensible for future structural upgrades beyond task history migration. Signed-off-by: Eric Wheeler <[email protected]>
- Add tests for cross-workspace functionality - Verify items can be found in all workspaces where they existed - Ensure workspace property reflects the latest workspace - Add tests for helper functions and edge cases Signed-off-by: Eric Wheeler <[email protected]>
- Removed pass-through state tests from ContextProxy that no longer apply - Updated ClineProvider tests to use file-based history instead of global state - Modified ChatTextArea tests to use useTaskSearch hook instead of taskHistory prop - Completely rewrote useTaskSearch tests to use message-based architecture - Updated other tests to remove taskHistory references from mock states Signed-off-by: Eric Wheeler <[email protected]> test: Fix ClineProvider test by mocking extension context and taskHistory This commit fixes the failing test 'correctly identifies subtask scenario for issue #4602' by: 1. Adding necessary Vitest imports 2. Mocking getExtensionContext to return a mock context with globalStorageUri 3. Mocking taskHistory module to prevent file system operations during tests Signed-off-by: Eric Wheeler <[email protected]>
Added missing translations across all 17 supported locales: - upgrade.* keys in common.json for task history index upgrade UI - workspace.unknown, workspace.available, workspace.recent, workspace.filterPlaceholder in history.json - limit.* keys and noItemsFound in history.json for pagination controls All translations now complete with proper localization for: - Catalan, German, Spanish, French, Hindi, Indonesian, Italian - Japanese, Korean, Dutch, Polish, Portuguese (Brazil) - Russian, Turkish, Vietnamese, Chinese (Simplified/Traditional) Fixes missing UI text that would appear in English fallback Signed-off-by: Eric Wheeler <[email protected]>
Implement a comprehensive task history management system with UI tools for scanning, diagnosing, and repairing history issues: - Add new HistoryScanResults and HistoryRebuildOptions interfaces - Refactor reindexHistoryItems into modular components: - scanTaskHistory: Identifies valid, orphaned, and missing tasks - rebuildIndexes: Rebuilds indexes with configurable options - reconstructTask: Recovers orphaned tasks from UI messages - Create new HistoryIndexTools UI component with: - Task history scanning capabilities - Configurable rebuild options (merge/replace modes) - Task preview and inspection tools - Real-time operation logging - Improve error handling and provide detailed logging - Update message handlers and type definitions - Add comprehensive translations for the new UI This change helps users diagnose and fix task history inconsistencies between global state and filesystem, preventing "lost" tasks and improving history reliability. Signed-off-by: Eric Wheeler <[email protected]> fix: prevent ReDoS vulnerability in log message regex Replace non-greedy wildcard pattern (.*?) with a more specific character class [^\]]* to avoid potential catastrophic backtracking on malicious input. This addresses a security vulnerability where the regex could run slow on strings starting with '[]' and containing many repetitions of '\t'. Signed-off-by: Eric Wheeler <[email protected]> fix: replace regex with string indexes in logMessage Replace regex pattern with string index operations in logMessage function to avoid potential ReDoS (Regular Expression Denial of Service) vulnerabilities. The change uses indexOf and substring instead of regex matching, which is more efficient and safer for processing log messages with tags. Signed-off-by: Eric Wheeler <[email protected]> refactor: implement mutual exclusion for history operations Created a mutex pattern to ensure history operations are mutually exclusive. This prevents concurrent execution of reindexHistoryItems and search operations, maintaining data consistency during indexing. Extracted common mutex logic into a reusable _withMutex helper function. Signed-off-by: Eric Wheeler <[email protected]> feat: add bidirectional sync with legacy globalState Adds capability to synchronize tasks between the new file-based history system and legacy VSCode globalState storage: - Renamed mergeGlobal to mergeFromGlobal for clarity - Added new mergeToGlobal option to update globalState with file index data - Added tracking of tasks that exist only in file indexes via tasksOnlyInTaskHistoryIndexes - Added developer UI controls in advanced section for managing globalState sync - Updated tests and documentation to reflect new bidirectional capabilities This feature enables backward compatibility testing with older versions of Roo Code by ensuring tasks created in the new storage format are also available in the legacy format. Signed-off-by: Eric Wheeler <[email protected]> refactor: make rebuildIndexes private by renaming to _rebuildIndexes This change makes the rebuildIndexes function private by adding an underscore prefix to its name, following the project's convention for private functions. All references to this function have been updated accordingly in both the implementation and test files. Signed-off-by: Eric Wheeler <[email protected]>
Add translations for task history reindexing features across all supported languages: - Add backend translations for history reindex success/failure messages - Add frontend translations for the history index tools UI - Update settings and common translation files for all locales Signed-off-by: Eric Wheeler <[email protected]>
KJ7LNW
force-pushed
the
refactor-use-files-for-history-scanner
branch
from
45ff20a to
3b985d1
Compare
Simplifies the task history recovery interface by moving all recovery and rebuild options into a single collapsed 'Advanced' section. This addresses feedback that the previous UI was too complex for users who just need to quickly restore tasks. The main 'Rebuild' and 'Rescan' action buttons remain directly visible, while all configuration checkboxes and mode selections are now neatly tucked away, available on-demand, and default to sensible values for a simple 'fix it' experience. Signed-off-by: Eric Wheeler <[email protected]>
Contributor
Author
|
All configuration checkboxes and mode selections are now neatly tucked away, and default to sensible values for a simple 'fix it' experience: 
|
KJ7LNW
moved this from PR [Changes Requested]
to PR [Needs Prelim Review]
in Roo Code Roadmap
Contributor
|
Generated with ❤️ by ellipsis.dev |
hannesrudolph
added
PR - Needs Preliminary Review
and removed
PR - Changes Requested
labels
Contributor
Author
|
Closing this for now because it is not that important, but the following are critical, so please review them first: |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to Reviewer
This is a PR series, so the line numbers shown by Github are exaggerated. The commit series clearly marks where each PR begins using lines that say
NOTICE: PR ____ STARTS HEREThe commits tell a clean story, it will be easier to understand what is happening here by looking at each commit individually under "Commits" than by looking at all of the files that were changed.
Dependencies
fix: use safeWriteJson for all JSON file writes with race condition fix #4733 (complete)This pull request implements a comprehensive task history management system with UI tools for scanning, diagnosing, and repairing history issues.
Actual diff without tests or langs:
Context
This PR addresses issue #5545 by providing tools to recover tasks that were lost due to global state race conditions. While issue #5544 prevents future task loss, this PR focuses on recovering tasks that were already lost before that fix.
Implementation
History Index Tools
Missing/Orphaned Task Preview
Orphaned Task Recovery
UI Index Scan Logs
UI Index Rebuild Logs
After Recovery
How to Test
Fixes #5545