-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: add comprehensive error telemetry to code-index service #5595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No security or compliance issues detected. Reviewed everything up to 07ebf19. Security Overview
Detected Code Changes
Reply to this PR with |
2c82d75 to
51de1b0
Compare
- Add new CODE_INDEX_ERROR telemetry event type - Implement error tracking across all code-index components: - Scanner: track file scanning and processing errors - Parser: track parsing failures and language detection issues - File watcher: track file system monitoring errors - Orchestrator: track coordination and workflow errors - Cache manager: track cache operations and persistence errors - Search service: track search and indexing errors - Manager: track initialization and lifecycle errors - Service factory: track service creation errors This improves observability and debugging capabilities for the code indexing system.
51de1b0 to
c850f89
Compare
- Mock TelemetryService.instance in all code-index test files to prevent initialization errors - Adjust expectation in openai.spec.ts for error with failing toString method to match Vitest behavior - All 325 code-index tests now pass successfully
- Replace individual error telemetry events with aggregated reporting - Collect errors during batch processing and send single consolidated event - Include error count, type breakdown, and sanitized examples - Add comprehensive tests for error aggregation behavior
…reController mock
- Remove complex error aggregation logic - Remove _createErrorSummary method - Report only batch-level errors to telemetry, not individual file errors - Maintain error sanitization using sanitizeErrorMessage - Simplify method signatures by removing aggregatedErrors parameters
mrubens
approved these changes
Jul 12, 2025
chrarnoldus
added a commit
to Kilo-Org/kilocode
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
PR - Needs Review
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive error telemetry to the code-index service while ensuring user privacy and maintaining code consistency.
Changes
Error Telemetry
Privacy Protection
Code Consistency
@shared/types/telemetrythroughout the codebaseTesting
Related Issues
Important
Adds comprehensive error telemetry to code-index service, ensuring privacy by hashing file paths and standardizing telemetry imports.
cache-manager.ts,manager.ts, andorchestrator.ts.@shared/types/telemetry.This description was created by
for 07ebf19. You can customize this summary. It will automatically update as commits are pushed.