Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Jul 11, 2025

Closes: #5623

Summary

Adds a checkbox to enable/disable the code indexing feature in settings.

Changes

  • Added checkbox control in CodeIndexPopover component
  • Implemented state persistence across sessions
  • Service stops when feature is disabled
  • UI refinement: moved description to tooltip
  • Updated all translations to remove "experimental" status

Testing

  • Checkbox state persists after restart
  • Indexing service properly starts/stops based on setting
  • All tests pass

Important

Adds a toggle in CodeIndexPopover to enable/disable code indexing, with state persistence and service control, and updates translations and tests.

  • Behavior:
    • Adds a checkbox in CodeIndexPopover to enable/disable code indexing.
    • Persists checkbox state across sessions.
    • Stops indexing service when disabled.
    • Moves description to tooltip in CodeIndexPopover.
  • Translations:
    • Updates translations in settings.json files to remove "experimental" status.
  • Testing:
    • Ensures checkbox state persists after restart.
    • Verifies indexing service starts/stops based on setting.
    • All tests pass in config-manager.spec.ts.

This description was created by Ellipsis for 6cabfa0. You can customize this summary. It will automatically update as commits are pushed.

- Add checkbox to enable/disable code indexing in settings
- Persist enabled state across sessions
- Stop indexing service when feature is disabled
- Move description to tooltip for consistent UI
- Update translations to remove experimental status
@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners July 11, 2025 14:57
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Jul 11, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jul 11, 2025

No security or compliance issues detected. Reviewed everything up to 6cabfa0.

Security Overview
  • 🔎 Scanned files: 25 changed file(s)
Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@daniel-lxs daniel-lxs marked this pull request as draft July 11, 2025 14:59
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 11, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Jul 11, 2025
@hannesrudolph hannesrudolph added PR - Draft / In Progress and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 11, 2025
This commit fixes two critical issues in the CodeIndexPopover component:

1.  Resolves a bug where saved API keys (displayed as placeholders) were cleared from input fields when settings were saved. The logic now correctly preserves existing secrets on the backend.
2.  Ensures the  toggle state is properly persisted across save operations, providing reliable control over the indexing action buttons.
@daniel-lxs daniel-lxs marked this pull request as ready for review July 12, 2025 16:05
@daniel-lxs daniel-lxs moved this from PR [Draft / In Progress] to PR [Needs Review] in Roo Code Roadmap Jul 12, 2025
@dosubot dosubot bot added the UI/UX UI/UX related or focused label Jul 12, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jul 12, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2025
@mrubens mrubens merged commit 5bffebd into main Jul 12, 2025
17 checks passed
@mrubens mrubens deleted the feat/code-index-enable-disable branch July 12, 2025 16:55
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jul 12, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 12, 2025
@hannesrudolph
Copy link
Collaborator

Toggle > checkbox

chrarnoldus added a commit to Kilo-Org/kilocode that referenced this pull request Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:XL This PR changes 500-999 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

feat: disable "Codebase Indexing" once it's enabled

4 participants