-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: add enable/disable toggle for code indexing #5599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add checkbox to enable/disable code indexing in settings - Persist enabled state across sessions - Stop indexing service when feature is disabled - Move description to tooltip for consistent UI - Update translations to remove experimental status
|
✅ No security or compliance issues detected. Reviewed everything up to 6cabfa0. Security Overview
Detected Code ChangesThe diff is too large to display a summary of code changes. Reply to this PR with |
This commit fixes two critical issues in the CodeIndexPopover component: 1. Resolves a bug where saved API keys (displayed as placeholders) were cleared from input fields when settings were saved. The logic now correctly preserves existing secrets on the backend. 2. Ensures the toggle state is properly persisted across save operations, providing reliable control over the indexing action buttons.
mrubens
approved these changes
Jul 12, 2025
Collaborator
|
Toggle > checkbox |
chrarnoldus
added a commit
to Kilo-Org/kilocode
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
PR - Needs Review
size:XL
This PR changes 500-999 lines, ignoring generated files.
UI/UX
UI/UX related or focused
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5623
Summary
Adds a checkbox to enable/disable the code indexing feature in settings.
Changes
Testing
Important
Adds a toggle in
CodeIndexPopoverto enable/disable code indexing, with state persistence and service control, and updates translations and tests.CodeIndexPopoverto enable/disable code indexing.CodeIndexPopover.settings.jsonfiles to remove "experimental" status.config-manager.spec.ts.This description was created by
for 6cabfa0. You can customize this summary. It will automatically update as commits are pushed.