-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Housekeeping/cleanup to unblock development #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: f14ba35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
For clarity - the QA test failures are the path-related tests that I fixed in the PR :) |
|
|
||
| it("should return basename when path equals cwd", () => { | ||
| const cwd = "/Users/test/project" | ||
| const cwd = createPath("C:", "Users", "test", "project") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add more test for window not replace like this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, took a stab at fix.
|
Closing stale PR; project config drift since PR was drafted is significant enough that the incremental value falls below the maintenance cost. |
Scope is various housekeeping/cleanup to unblock productive dev work.
Description
Existing issues fixed:
npm buildfail due to lack of cleanup of /bin and incorrect parsing of-pflagsrc/testfails to run.src/testuses Mocha (inconsistent for use of Jest in 700+ other tests across the code base)Issues identified and not fixed:
"Unexpected: No existing API conversation history"error. Attempted to debug by logging a warning and returning in the relevant case - was consistently met with recursion stack limit or zombie process issues. Recommend prioritizing a look at this for triage purposes to understand if the error is masking a more fundamental issue or whether can be fixed with better cleanup after test execution.Type of change
How Has This Been Tested?
npm run testnpm run buildChecklist:
Reviewers
@mrubens
ETA: I am not familiar with changesets and added one when prompted to at commit time; ignore if not relevant.
Important
Fix build and test issues, enhance linting, and improve logging for better development efficiency.
npm buildfailures by cleaning/binand correcting-pflag parsing.path.test.ts.jest.config.jsto includesrcdirectory for tests and switch from Mocha to Jest insrc/test..eslintrc.jsonto enable stricter linting rules as warnings.lintandlint:fixscripts inpackage.json.Cline.ts,ClineProvider.ts, andprocess-images.ts.jest.config.jsand addjest.debug.config.jsfor detailed output.jest-custom-reporter.jsfor concise test summaries.cleanscript topackage.jsonfor cleaning build artifacts.McpHub.test.tssuite and add TODO for fixing.This description was created by
for 40dedcf. It will automatically update as commits are pushed.