Skip to content

Conversation

@hamirmahal
Copy link

@hamirmahal hamirmahal commented Jul 13, 2025

Related GitHub Issue

Closes: #5674

Description

The publish-nightly job has 2 warnings:

Post Setup Node.js and pnpm
Unexpected input(s) 'skip-checkout', valid inputs are ['node-version', 'pnpm-version', 'skip-install', 'install-args']
Setup Node.js and pnpm
Unexpected input(s) 'skip-checkout', valid inputs are ['node-version', 'pnpm-version', 'skip-install', 'install-args']

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Documentation Updates

  • No documentation updates are required.

Important

Remove redundant skip-checkout input from nightly-publish.yml to fix warnings.

  • Behavior:
    • Removes skip-checkout input from Setup Node.js and pnpm step in nightly-publish.yml to eliminate warnings.
  • Warnings:
    • Addresses warnings about unexpected input skip-checkout in publish-nightly job.

This description was created by Ellipsis for 4515fe4. You can customize this summary. It will automatically update as commits are pushed.

@hamirmahal hamirmahal requested review from cte, jr and mrubens as code owners July 13, 2025 22:14
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 13, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 13, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jul 13, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 13, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hamirmahal

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 14, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jul 14, 2025
@hamirmahal
Copy link
Author

You're welcome, @daniel-lxs!

@daniel-lxs
Copy link
Member

Hey @hamirmahal We really appreciate your contribution! It seems that #5676 also addresses other files where this error is occurring.

That said, the credit for discovering the bug definitely goes to you, thank you!

@daniel-lxs daniel-lxs closed this Jul 15, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 15, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jul 15, 2025
@hamirmahal hamirmahal deleted the refactor/remove-redundant-skip-checkout-input branch July 15, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Needs Review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

The publish-nightly logs have 2 warnings

3 participants