Skip to content

Conversation

@psv2522
Copy link
Contributor

@psv2522 psv2522 commented Jan 26, 2025

Description

Fixes issue #562

Type of change

Added appropriate styling for all relevant option tags

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manual installation.

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation

Additional context

image
image

Related Issues

#562

Reviewers


Important

Fixes styling of select options in ChatTextArea.tsx by applying consistent optionStyle.

  • Styling:
    • Introduced optionStyle for consistent styling of option elements in ChatTextArea.tsx.
    • Applied optionStyle to all option elements to ensure consistent background and foreground colors.
    • Ensures dropdown options match VSCode theme colors.

This description was created by Ellipsis for 63787d1. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2025

⚠️ No Changeset found

Latest commit: 2d65b8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

backgroundColor: "var(--vscode-dropdown-background)",
color: "var(--vscode-dropdown-foreground)",
}}>
<option key={mode.slug} value={mode.slug} style={{ ...optionStyle }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider extracting repeated inline styles for select and option elements into a shared utility or CSS module for better maintainability. This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818094a05ef707e188c0d5

@mrubens mrubens merged commit 601ede7 into RooCodeInc:main Jan 26, 2025
4 checks passed
@psv2522 psv2522 deleted the fix-issue-562 branch January 26, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants