feat: improve rate limit handling for Gemini embedder #5790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add jitter (0-20%) to exponential backoff to prevent thundering herd - Extend retry support to transient errors (500, 502, 503, 504) - Add isRetryableError() helper method for centralized retry logic - Update tests to cover new retry behavior and jitter functionality - Improve reliability for Gemini and all OpenAI-compatible embedders
|
✅ No security or compliance issues detected. Reviewed everything up to ad6e5f2. Security Overview
Detected Code Changes
Reply to this PR with |
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Draft / In Progress
and removed
Issue/PR - Triage
github-project-automation
bot
moved this from PR [Draft / In Progress]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves rate limit handling for Gemini and all OpenAI-compatible embedders by adding exponential backoff with jitter and retry support for transient errors.
Changes
isRetryableError()helper for centralized retry logicBenefits
All tests pass ✅