Skip to content

fix: resolve OpenAI Compatible embedder provider save validation issue #5843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: resolve OpenAI Compatible embedder provider save validation issue #5843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion webview-ui/src/components/chat/CodeIndexPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,20 @@ export const CodeIndexPopover: React.FC<CodeIndexPopoverProps> = ({
dataToValidate[key] = "placeholder-valid"
}
} else {
dataToValidate[key] = value
// Special handling for model dimension field - ensure it's a number when required
if (key === "codebaseIndexEmbedderModelDimension") {
// For OpenAI Compatible provider, this field is required and must be a number
if (currentSettings.codebaseIndexEmbedderProvider === "openai-compatible") {
// Convert to number if it's a string, or use undefined if empty
const numValue = typeof value === "string" ? parseInt(value, 10) : (value as number)
dataToValidate[key] = isNaN(numValue) ? undefined : numValue
} else {
// For other providers, it's optional
dataToValidate[key] = value
}
} else {
dataToValidate[key] = value
}
}
}

Expand Down