Improve edit scrolling #590
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves diff handling and streaming performance in the DiffViewProvider through two main changes:
Enhanced diff algorithm implementation:
Optimized streaming performance:
Type of change
How Has This Been Tested?
The changes have been tested through:
The changes have NOT been tested through:
Checklist:
Additional context
This refactor significantly improves the performance and reliability of the diff view streaming functionality, particularly for large files. The chunk-based approach with dynamic sizing ensures smooth visualization while maintaining responsiveness.
Related Issues
Improves performance and reliability for #diff-streaming #large-files
Reviewers
@hannesrudolph
Important
Enhances diff handling and streaming performance in
DiffViewProvider.tswith improved diff algorithm and chunk-based updates.diff.diffLines()inscrollToFirstDiff().saveChanges().update()with dynamic sizing and 10ms delay.scrollEditorToLine()for smoother appearance.autoFormattingEditstosaveChanges()return value.scrollEditorToLine()to scroll only if needed.This description was created by
for 7e64a96. It will automatically update as commits are pushed.