Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jul 18, 2025

This PR addresses issue #5927 by implementing comprehensive improvements to tool call failure handling and error recovery mechanisms.

Key changes:

  • Enhanced error handling in presentAssistantMessage.ts with better tool error tracking
  • Improved ToolRepetitionDetector with contextual failure history and intelligent error messages
  • Added enhanced logging and debugging information for tool failures
  • Updated error messages to be more helpful and actionable with specific suggestions
  • Added telemetry tracking for tool validation and execution failures
  • Improved consecutive mistake handling with better user guidance

This should significantly reduce the Roo is having trouble scenarios by providing better guidance when tools fail and helping users understand what went wrong and how to fix it.

Fixes #5927


Important

Improves error handling, logging, and user guidance for tool failures, and adds telemetry tracking in various components.

  • Error Handling:
    • Enhanced error handling in presentAssistantMessage.ts with improved tool error tracking and telemetry.
    • Updated formatResponse.toolError() in responses.ts to include suggestions based on error patterns.
    • Improved ToolRepetitionDetector in ToolRepetitionDetector.ts with contextual failure history and intelligent error messages.
  • Telemetry and Logging:
    • Added telemetry tracking for tool validation and execution failures in presentAssistantMessage.ts.
    • Enhanced logging for debugging tool failures in Task.ts.
  • User Guidance:
    • Updated error messages in responses.ts to be more helpful and actionable.
    • Improved consecutive mistake handling in Task.ts with better user guidance.

This description was created by Ellipsis for 038aeec. You can customize this summary. It will automatically update as commits are pushed.

- Enhanced error handling in presentAssistantMessage.ts with better tool error tracking
- Improved ToolRepetitionDetector with contextual failure history and intelligent error messages
- Added enhanced logging and debugging information for tool failures
- Updated error messages to be more helpful and actionable with specific suggestions
- Added telemetry tracking for tool validation and execution failures
- Improved consecutive mistake handling with better user guidance

Fixes #5927
@roomote roomote bot requested review from cte, jr and mrubens as code owners July 18, 2025 21:25
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Jul 18, 2025
@roomote roomote bot mentioned this pull request Jul 18, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 18, 2025
@daniel-lxs
Copy link
Member

Closing due to lack of scoping in the issue

@daniel-lxs daniel-lxs closed this Jul 19, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 19, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Constant Tool Call Faillures

4 participants