fix: resolve viewId inconsistency in WebPreviewProvider #5982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement WebPreviewProvider for managing preview panel - Add element selection overlay with DOM inspection - Extract comprehensive element context (HTML, CSS, position, etc.) - Integrate selected element context with AI chat - Add responsive controls and device simulation - Support multiple device viewports (mobile, tablet, desktop) - Handle cross-origin restrictions gracefully - Add comprehensive tests for WebPreviewProvider - Update documentation with usage guide Closes #5971
- Validate and sanitize URLs before loading in iframe - Use URL constructor to parse and validate URLs - Only allow HTTP and HTTPS protocols - Use setAttribute instead of direct property assignment - Add proper error handling for invalid URLs This fixes: - Client-side URL redirect vulnerability - DOM text reinterpreted as HTML - Client-side cross-site scripting (XSS)
- Changed viewId from "roo-code.webPreview" to "roo-cline.WebPreviewProvider" to match package.json and registerCommands.ts - This fixes the issue identified by ellipsis-dev bot in PR #5981 - Security vulnerabilities were already fixed in the original PR
dosubot
bot
added
size:XXL
hannesrudolph
added
the
Issue/PR - Triage
Collaborator
|
@daniel-lxs This PR is also not good. You can close this too . I'm working on the version myself . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the viewId inconsistency issue identified in PR #5981.
Changes
"roo-code.webPreview"to"roo-cline.WebPreviewProvider"inWebPreviewProvider.tsto match the ID used inpackage.jsonandregisterCommands.tsContext
This fix addresses the review comment from ellipsis-dev bot in PR #5981. The security vulnerabilities mentioned in the GitHub Advanced Security comments were already addressed in the original PR through proper URL validation and sanitization.
Testing
Relates to #5971
Important
Fixes
viewIdinconsistency inWebPreviewProviderand adds documentation and tests for the Web Preview feature.viewIdfrom"roo-code.webPreview"to"roo-cline.WebPreviewProvider"inWebPreviewProvider.tsto matchpackage.jsonandregisterCommands.ts.docs/web-preview.mdto document the Web Preview feature.WebPreviewProvider.spec.tsto cover new functionality.openWebPreviewcommand inregisterCommands.tsto focus on the web preview panel.README.mdto include web application preview feature.preview.jsineslint.config.mjs.This description was created by
for a125c4b. You can customize this summary. It will automatically update as commits are pushed.