-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: Progressive migration to newer Gemini models and naming conventions #5990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
HahaBill
wants to merge
26
commits into
RooCodeInc:main
from
HahaBill:i/update-gemini-and-vertex-models
Closed
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
2816191
fix: creating a list of legacy Gemini models in both gemini.ts and ve…
HahaBill 5f326c4
fix: progressive migration to new Gemini naming conventions on both f…
HahaBill 6dab2cd
fix: gemini-1.5 and gemini-exp to be migrated to geminiDefaultModelId
HahaBill 3122b41
fix: making changes based on the AI code reviewer
HahaBill 642507e
fix: updating unit tests
HahaBill 6c7f188
Merge branch 'RooCodeInc:main' into i/update-gemini-and-vertex-models
HahaBill c45802b
fix: adding more migration changes and unit tests
HahaBill 136ff00
Merge branch 'RooCodeInc:main' into i/update-gemini-and-vertex-models
HahaBill 43f10e3
fix: adding mapping on the frontend-side
HahaBill 7f81d79
Merge branch 'i/update-gemini-and-vertex-models' of https://github.co…
HahaBill 1a4a7a5
fix: updaing model id for existing unit tests and handling gemini-2.5…
HahaBill 2f2df3f
fix: updating existing unit tests
HahaBill 832d298
fix: updating the existing test to adapt to from
HahaBill a4f25a2
Merge branch 'RooCodeInc:main' into i/update-gemini-and-vertex-models
HahaBill 9975e3e
Merge branch 'main' into i/update-gemini-and-vertex-models
HahaBill 6530965
Merge branch 'RooCodeInc:main' into i/update-gemini-and-vertex-models
HahaBill 9a1bc43
fix: remove duplicated function and tested the functionality in debug…
HahaBill ffb42ca
fix: preventing dirty state for Gemini naming convention migration
HahaBill fa7cd5d
Merge branch 'RooCodeInc:main' into i/update-gemini-and-vertex-models
HahaBill 2d11ee3
fix: persistently storing new Gemini migrations
HahaBill f5c5590
Merge branch 'main' into i/update-gemini-and-vertex-models
HahaBill 02874b5
Merge branch 'RooCodeInc:main' into i/update-gemini-and-vertex-models
HahaBill e053aad
Merge branch 'RooCodeInc:main' into i/update-gemini-and-vertex-models
HahaBill bf7a637
Merge branch 'RooCodeInc:main' into i/update-gemini-and-vertex-models
HahaBill 07179ba
Merge branch 'RooCodeInc:main' into i/update-gemini-and-vertex-models
HahaBill 432abe3
Merge branch 'RooCodeInc:main' into i/update-gemini-and-vertex-models
HahaBill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the new change that I did, I realised that it wasn't persistently stored. We don't need the legacy mapping in
gemini.tsanymore but we can leave it there just for the extra security.Overall: we should have a clean ap state now with migrations being persistently stored with doing upsert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.