fix: validate commands against allowed/denied lists before execution #5998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add validation in executeCommandTool to check commands against user-configured allowed and denied command lists - Denied commands take precedence over allowed commands - Empty command strings in lists are ignored - Add comprehensive tests for command validation scenarios - Fixes #5997 where Roo executed commands outside the allowed command set
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| if (isDenied) { | ||
| await cline.say( | ||
| "error", | ||
| `Command '${baseCommand}' is in the denied commands list and cannot be executed.`, |
Contributor
There was a problem hiding this comment.
Consider using the internationalization function (t) for error messages instead of hardcoding them (e.g. for denied commands). This ensures UI consistency with other translatable strings.
Suggested change
| `Command '${baseCommand}' is in the denied commands list and cannot be executed.`, | |
| t('common:errors:command_denied', { command: baseCommand }), |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
hannesrudolph
added
the
Issue/PR - Triage
Member
|
The issue needs some scoping to properly fix the potential issue, closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5997 where Roo executed commands outside the configured allowed command set.
This PR adds validation in executeCommandTool to check commands against user-configured allowed and denied command lists before execution. Denied commands take precedence over allowed commands.
See PR description for full details.
Important
Adds command validation in
executeCommandToolto check against allowed/denied lists before execution, with tests to verify behavior.executeCommandToolto check against allowed/denied lists before execution.alwaysAllowExecuteis true.executeCommandValidation.spec.tsto verify command validation logic.executeCommandTool.tsto include validation logic and handle command execution accordingly.This description was created by
for 5466af4. You can customize this summary. It will automatically update as commits are pushed.