fix: prevent Kimi K2 model from completing tasks without performing actions #6000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #5999 where the Kimi K2 model immediately marks tasks as completed without actually performing any fixes.
Changes Made
Added validation in attemptCompletionTool to check if actual work was done before allowing completion
Added model-specific instructions in the system prompt for Kimi K2 models
Added telemetry tracking for premature completion attempts
Comprehensive test coverage for the new validation logic
Testing
Fixes #5999
Important
Adds validation to ensure Kimi K2 model performs actions before marking tasks as complete, with model-specific instructions and telemetry tracking.
attemptCompletionToolto ensure Kimi K2 model performs actions before task completion.getRulesSection()inrules.ts.attempt_completion.attemptCompletionTool.attemptCompletionTool.spec.tsfor Kimi K2 validation logic.This description was created by
for 74d6c57. You can customize this summary. It will automatically update as commits are pushed.