feat: Add file-based editing mode to bypass diff view (#6001) #6002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created IEditingProvider interface to abstract file editing operations - Implemented FileWriter class for direct file system writes without diff view - Updated Task class to use IEditingProvider interface instead of DiffViewProvider directly - Added fileBasedEditing setting to global settings and UI - Updated all file editing tools to use the new interface - Added comprehensive tests for FileWriter class - Updated existing tests to work with the new interface This feature allows users to skip the diff view and apply edits directly to files, which is useful for users who prefer to review changes in their own editor or version control system.
dosubot
bot
added
size:XL
4 tasks
- Added fileEditing section to navigation menu in all languages - Added complete fileEditing configuration translations - Maintains consistency across all 17 language files - Fixes failing translation check in CI
hannesrudolph
added
the
Issue/PR - Triage
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| "language": "语言", | ||
| "about": "关于 Roo Code" | ||
| "about": "关于 Roo Code", | ||
| "fileEditing": "File Editing" |
Contributor
There was a problem hiding this comment.
The new fileEditing key (and its subkeys) is still in English. For a proper localized user experience, please translate these strings into Chinese. For example, replace 'Enable file-based editing mode' and 'Show diff view' with appropriate Chinese translations.
Suggested change
| "fileEditing": "File Editing" | |
| "fileEditing": "文件编辑" |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| "language": "語言", | ||
| "about": "關於 Roo Code" | ||
| "about": "關於 Roo Code", | ||
| "fileEditing": "File Editing" |
Contributor
There was a problem hiding this comment.
The new fileEditing key (and related labels) remains in English. Please provide Traditional Chinese translations for these file-based editing mode texts to ensure full localization.
Suggested change
| "fileEditing": "File Editing" | |
| "fileEditing": "檔案編輯" |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
Member
|
To be implemented by @felixAnhalt, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements file-based editing mode that allows users to bypass the diff view and apply edits directly to files.
See issue #6001 for details.
Changes:
When enabled, file edits are written directly without showing the diff view.
Important
Introduces file-based editing mode for direct file writes, bypassing diff view, with new interface, class, and settings updates.
fileBasedEditingsetting inglobal-settings.tsand UI components.IEditingProviderinterface for file editing operations.FileWriterclass for direct file system writes.Taskclass to useIEditingProviderinstead ofDiffViewProvider.FileWriterinFileWriter.spec.ts.fileBasedEditingoption.webviewMessageHandler.tsto handlefileBasedEditingsetting changes.diffViewProvidertoeditingProviderin multiple files.This description was created by
for 4bac5aa. You can customize this summary. It will automatically update as commits are pushed.