feat: implement auto-close Roo tabs feature #6015
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add autoCloseRooTabs and autoCloseAllRooTabs settings to global settings - Create PostEditBehaviorUtils class to handle tab closing logic - Update DiffViewProvider to track Roo-opened tabs and close them after save - Add FileEditingOptions component for settings UI - Update SettingsView and webviewMessageHandler to support new settings - Add tests for PostEditBehaviorUtils (some mocking issues to be resolved) Closes #6003
dosubot
bot
added
size:XL
hannesrudolph
added
the
Issue/PR - Triage
- Fixed logic to only close the edited file when autoCloseRooTabs is true but autoCloseAllRooTabs is false - Updated tests to properly mock vscode.window.tabGroups.close() method - Added isDirty property to test tab mocks
Member
|
To be implemented by @felixAnhalt, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the auto-close Roo tabs feature as requested in #6003. It adds two new settings that allow users to automatically close tabs that were opened by Roo after saving changes.
New Settings
Implementation Details
Testing
Closes #6003
Important
Introduces auto-close feature for Roo-opened tabs with new settings, UI components, and utility functions.
autoCloseRooTabsandautoCloseAllRooTabssettings toglobal-settings.tsfor automatic tab closure after editing.PostEditBehaviorUtilswith methodscloseRooTabs()andrestoreFocus().DiffViewProviderto track and close tabs based on new settings.FileEditingOptionscomponent to manage new settings in the UI.SettingsViewto include file editing options.PostEditBehaviorUtilsinPostEditBehaviorUtils.spec.ts.This description was created by
for d7d9bad. You can customize this summary. It will automatically update as commits are pushed.