feat: improve Azure OpenAI compatibility #6033
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced Azure detection logic to match Cline implementation - Added URL extraction for Azure endpoints with query parameters - Fixed reasoning model handling for Azure (o1, o3, o4) - Added specific error messages for common Azure issues - Addresses issue #1334
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| // Primary indicator is azureApiVersion, then check URL patterns | ||
| const isAzureOpenAi = !!( | ||
| this.options.azureApiVersion || | ||
| options.openAiUseAzure || |
Contributor
There was a problem hiding this comment.
Typographical error: did you mean this.options.openAiUseAzure instead of options.openAiUseAzure? This would make the reference consistent with other options.
Suggested change
| options.openAiUseAzure || | |
| this.options.openAiUseAzure || |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hannesrudolph
added
the
Issue/PR - Triage
Collaborator
|
@roomote-agent run issue-fixer mode on this pr |
Contributor
Author
|
Hi @hannesrudolph! I see your request to run issue-fixer mode on this PR. I notice the CodeQL check is currently failing. Let me investigate and fix the issues. 🔧 |
- Remove @ts-ignore comments and use proper type assertions - Add input validation and sanitization for error messages - Improve URL parsing error handling in _extractBaseUrl method - Prevent potential security vulnerabilities flagged by CodeQL
- Replace insecure .includes() checks with proper hostname validation - Add _isAzureHost() method to safely check for Azure domains - Add _isVolcesHost() method to safely check for Volces domains - Prevent security vulnerabilities from malicious URLs like malicious-azure.com.attacker.com
Contributor
Author
|
Hi @hannesrudolph! ✅ I have successfully fixed all the CodeQL issues in this PR. Summary of fixes:1. Fixed TypeScript type safety issues
2. Resolved CodeQL security vulnerabilities
3. Improved error handling
All CI checks are now passing, including the CodeQL security scan. The Azure OpenAI compatibility improvements are ready for review! 🚀 |
hannesrudolph
added
PR - Draft / In Progress
and removed
Issue/PR - Triage
github-project-automation
bot
moved this from PR [Draft / In Progress]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves Azure OpenAI compatibility by implementing several key enhancements based on how Cline handles Azure connections.
Changes
1. Enhanced Azure Detection Logic
azureApiVersionas the primary indicator (similar to Cline)2. URL Handling for Azure Endpoints
_extractBaseUrl()method to properly handle Azure URLs with query parametershttps://resource.openai.azure.com/openai/deployments/model/chat/completions?api-version=2025-01-01-preview3. Reasoning Model Support (o1, o3, o4)
4. Better Error Handling
Testing
Related Issues
Context
As requested by @hannesrudolph, I examined how Cline implemented Azure AI Foundry connectivity and applied similar patterns to improve our implementation.
Important
Enhances Azure OpenAI compatibility by improving detection logic, URL handling, and error management in
openai.ts.azureApiVersionand URL patterns inOpenAiHandler._extractBaseUrl()inOpenAiHandlerto handle Azure URLs without query parameters.createMessage()andhandleO3FamilyMessage().createMessage().This description was created by
for 6319935. You can customize this summary. It will automatically update as commits are pushed.