fix: keep auto-approve checkbox responsive when menu is expanded #6062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove isExpanded from checkbox disabled condition to allow toggling while menu is open - Wrap onChange handler in useCallback to prevent unnecessary re-renders - Add tests to verify checkbox remains responsive when menu is expanded - Add test to verify no flickering during rapid state changes This fixes the critical safety issue where users could not disable auto-approval during model responses when they realized unintended actions were about to occur. Fixes #6060
hannesrudolph
added
the
Issue/PR - Triage
dosubot
bot
added
size:L
Member
|
Closing, handled by #6061 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical safety issue where the auto-approve checkbox becomes unresponsive when the dropdown menu is expanded, preventing users from disabling auto-approval during model responses.
Fixes #6060
Changes
Safety Impact
This fix ensures users can always disable auto-approval when needed, which is critical for preventing unintended actions during model responses.
Important
Fixes unresponsive auto-approve checkbox in
AutoApproveMenu.tsxwhen menu is expanded, ensuring it remains responsive and prevents unintended actions.AutoApproveMenu.tsxwhen dropdown is expanded by removingisExpandedfrom disabled condition.onChangehandler inuseCallbackto prevent unnecessary re-renders.AutoApproveMenu.spec.tsxto verify checkbox remains responsive when menu is expanded.This description was created by
for cdb9e41. You can customize this summary. It will automatically update as commits are pushed.