fix: prevent disabled MCP servers from starting processes and show correct status #6086
Conversation
…rrect status - Added disabled state checks in updateServerConnections() to prevent disabled servers from being connected - Updated frontend getStatusColor() to show grey for disabled servers - Modified UI rendering to show minimal interface for disabled servers without error messages or retry buttons - Added translation for disabled server status Fixes #6036
dosubot
bot
added
size:M
hannesrudolph
added
the
Issue/PR - Triage
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| "retrying": "Wiederhole...", | ||
| "retryConnection": "Verbindung wiederholen" | ||
| "retryConnection": "Verbindung wiederholen", | ||
| "disabled": "Server is disabled" |
There was a problem hiding this comment.
The string for the key "disabled" is in English ('Server is disabled') in a German locale file. Consider translating it to German (e.g., 'Server deaktiviert')
| "disabled": "Server is disabled" | |
| "disabled": "Server deaktiviert" |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| "retrying": "Reintentando...", | ||
| "retryConnection": "Reintentar conexión" | ||
| "retryConnection": "Reintentar conexión", | ||
| "disabled": "Server is disabled" |
There was a problem hiding this comment.
The string "Server is disabled" appears in English within a localization file that's otherwise in Spanish. Consider updating it to a Spanish equivalent (e.g., "Servidor deshabilitado") for consistency.
| "disabled": "Server is disabled" | |
| "disabled": "Servidor deshabilitado" |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| "retrying": "Nouvelle tentative...", | ||
| "retryConnection": "Réessayer la connexion" | ||
| "retryConnection": "Réessayer la connexion", | ||
| "disabled": "Server is disabled" |
There was a problem hiding this comment.
The new key "disabled" has the value "Server is disabled" in English, while the rest of the translations are in French. Consider using the French equivalent (e.g., "Serveur désactivé") for consistency.
| "disabled": "Server is disabled" | |
| "disabled": "Serveur désactivé" |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| "retrying": "Riprovo...", | ||
| "retryConnection": "Riprova connessione" | ||
| "retryConnection": "Riprova connessione", | ||
| "disabled": "Server is disabled" |
There was a problem hiding this comment.
The translation for the "disabled" status is currently in English ('Server is disabled'). Since this file is for the Italian locale, consider translating it into Italian for consistency.
| "disabled": "Server is disabled" | |
| "disabled": "Server disabilitato" |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| "retrying": "Ponawianie...", | ||
| "retryConnection": "Ponów połączenie" | ||
| "retryConnection": "Ponów połączenie", | ||
| "disabled": "Server is disabled" |
There was a problem hiding this comment.
The new string for the "disabled" key is in English, while the rest of the translations in this file are in Polish. Should this be localized to Polish (e.g., "Serwer jest wyłączony") for consistency?
| "disabled": "Server is disabled" | |
| "disabled": "Serwer jest wyłączony" |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| "retrying": "重试中...", | ||
| "retryConnection": "重试连接" | ||
| "retryConnection": "重试连接", | ||
| "disabled": "Server is disabled" |
There was a problem hiding this comment.
It looks like the translation for the key "disabled" is in English ('Server is disabled') whereas the rest of the file is in Chinese. If this isn't intentional, please update the text to Chinese (e.g., '已禁用').
| "disabled": "Server is disabled" | |
| "disabled": "已禁用" |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
Summary
This PR fixes the issue where disabled MCP servers were still starting processes and showing incorrect status indicators in the UI.
Changes
Backend (McpHub.ts)
updateServerConnections()method to prevent disabled servers from being connectedFrontend (McpView.tsx)
getStatusColor()to return grey color for disabled servers regardless of connection statusTranslations
Testing
Fixes
Fixes #6036
Important
Fixes issue where disabled MCP servers were incorrectly starting processes and showing wrong statuses, with UI and translation updates.
McpHub.ts):updateServerConnections()to prevent disabled servers from connecting.McpView.tsx):getStatusColor()now returns grey for disabled servers.This description was created by
for 86de02e. You can customize this summary. It will automatically update as commits are pushed.