Skip to content

fix: improve Azure OpenAI connectivity and reasoning model support #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
roomote wants to merge 1 commit into from
Closed

fix: improve Azure OpenAI connectivity and reasoning model support #6135

roomote wants to merge 1 commit into from

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jul 23, 2025 •
edited by ellipsis-dev bot
Loading

Summary

This PR improves Azure OpenAI connectivity by implementing the same approach used by Cline, addressing the issues reported in #1334.

Key Changes

  1. Enhanced Azure Detection Logic

    • Now uses azureApiVersion as the primary indicator for Azure endpoints (like Cline)
    • Falls back to URL pattern detection for compatibility

  2. URL Extraction Method

    • Added _extractAzureBaseUrl() method to properly handle Azure URLs with query parameters
    • Extracts base URL from full endpoint URLs (e.g., https://myresource.openai.azure.com/openai/deployments/gpt-4/chat/completions?api-version=2024-08-01-preview → https://myresource.openai.azure.com)

  3. Fixed Reasoning Model Support

    • Azure o1/o3/o4 models don't support "system" or "developer" roles
    • System prompts are now combined with the first user message for Azure endpoints
    • Maintains original behavior for non-Azure endpoints

  4. Better Error Messages

    • Added specific error handling for Azure initialization failures
    • Provides helpful guidance for common Azure configuration issues

Testing

  • All existing tests pass ✅
  • Tested with provider test suite: 412 tests passed

Fixes

Fixes #1334

Context

As requested by @potatoqualitee, I examined how Cline implemented Azure AI Foundry connectivity and identified the key differences that were causing issues in Roo Code.

Important

Improves Azure OpenAI connectivity and reasoning model support by enhancing detection logic, URL handling, and error messages in openai.ts.

  • Azure Detection Logic:
    • Uses azureApiVersion as primary indicator for Azure endpoints in OpenAiHandler.
    • Falls back to URL pattern detection.
  • URL Handling:
    • Adds _extractAzureBaseUrl() to extract base URL from Azure endpoint URLs in openai.ts.
  • Reasoning Model Support:
    • Combines system prompts with first user message for Azure models in handleO3FamilyMessage().
    • Maintains original behavior for non-Azure endpoints.
  • Error Handling:
    • Adds specific error messages for Azure initialization failures in OpenAiHandler.
    • Checks for Azure-specific errors in createMessage() and handleO3FamilyMessage().
  • Misc:

This description was created by Ellipsis for 6e9abec. You can customize this summary. It will automatically update as commits are pushed.

@roomote
fix: improve Azure OpenAI connectivity and reasoning model support
6e9abec 
- Use azureApiVersion as primary indicator for Azure detection (like Cline)
- Add URL extraction method to handle Azure URLs with query parameters
- Fix reasoning model support for Azure o1/o3/o4 models by handling system messages
- Add better error messages for Azure-specific issues

Fixes #1334
@roomote roomote bot requested review from cte, jr and mrubens as code owners July 23, 2025 20:10
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Jul 23, 2025
ellipsis-dev[bot]
ellipsis-dev bot reviewed Jul 23, 2025
View reviewed changes
src/api/providers/openai.ts
const urlHost = this._getUrlHost(this.options.openAiBaseUrl)
const isAzureOpenAi = urlHost === "azure.com" || urlHost.endsWith(".azure.com") || options.openAiUseAzure
// Use azureApiVersion as primary indicator (like Cline), then fall back to URL patterns
const isAzureOpenAi =
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enhanced Azure endpoint detection using azureApiVersion is clear, but the logic to compute isAzureOpenAi is repeated (e.g., here and again in createMessage). Consider extracting this check into a helper function to avoid redundancy.

src/api/providers/openai.ts
const requestOptions: OpenAI.Chat.Completions.ChatCompletionCreateParamsStreaming = {
model: modelId,
messages: [
// Azure doesn't support "developer" role, so we need to combine system prompt with first user message
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic to merge the system prompt with the first user message for Azure endpoints is duplicated in both streaming and non‐streaming branches (and also in handleO3FamilyMessage). Consider refactoring this into a utility/helper function to enhance maintainability.

This comment was generated because it violated a code review rule: irule_tTqpIuNs8DV0QFGj.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 23, 2025
View reviewed changes
src/api/providers/openai.ts
try {
const url = new URL(fullUrl)
// For Azure OpenAI, we want just the origin (protocol + host)
if (url.host.includes("azure.com")) {

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

'
azure.com
Loading
' can be anywhere in the URL, and arbitrary hosts may come before or after it.

Copilot Autofix

AI 5 months ago

To fix the issue, replace the substring check url.host.includes("azure.com") with a more robust validation mechanism that ensures the host matches an explicit whitelist of allowed domains. This approach prevents bypasses by malicious URLs and ensures that only legitimate Azure domains are accepted.

The fix involves:

  1. Defining a whitelist of allowed Azure domains (e.g., ["azure.com"]).
  2. Using url.host to check if the host matches one of the allowed domains exactly or ends with one of the allowed domains (to account for subdomains like services.ai.azure.com).

Changes are required in the _extractAzureBaseUrl method to implement this validation.

Suggested changeset 1
src/api/providers/openai.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/api/providers/openai.ts b/src/api/providers/openai.ts
--- a/src/api/providers/openai.ts
+++ b/src/api/providers/openai.ts
@@ -498,3 +498,4 @@
 			// For Azure OpenAI, we want just the origin (protocol + host)
-			if (url.host.includes("azure.com")) {
+			const allowedAzureDomains = ["azure.com"];
+			if (allowedAzureDomains.some(domain => url.host === domain || url.host.endsWith(`.${domain}`))) {
 				return url.origin
EOF
@@ -498,3 +498,4 @@
// For Azure OpenAI, we want just the origin (protocol + host)
if (url.host.includes("azure.com")) {
const allowedAzureDomains = ["azure.com"];
if (allowedAzureDomains.some(domain => url.host === domain || url.host.endsWith(`.${domain}`))) {
return url.origin
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 23, 2025
@roomote roomote bot mentioned this pull request Jul 23, 2025
Closed
@potatoqualitee
Copy link

potatoqualitee commented Jul 23, 2025

Dupe! I was quoting another post and it thought I was genuinely tagging it and not juts repeating within my quote. Please close.

@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jul 24, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 24, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Draft / In Progress] in Roo Code Roadmap Jul 28, 2025
@daniel-lxs daniel-lxs closed this Jul 28, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 28, 2025
@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellipsis-dev ellipsis-dev[bot] ellipsis-dev[bot] left review comments

@mrubens mrubens Awaiting requested review from mrubens mrubens is a code owner

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

bug Something isn't working PR - Needs Preliminary Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Connecting to Azure AI Foundry - OpenAI

5 participants

@potatoqualitee @hannesrudolph @daniel-lxs @roomote