Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jul 23, 2025

Summary

This PR fixes issue #6141 where the codestral-embed model fails with 3072 dimensions when used via the OpenAI-compatible provider.

Problem

When users configure the OpenAI-compatible provider to use the codestral-embed model with 3072 dimensions, the system was unable to find the dimension configuration and would fall back to default behavior, causing a dimension mismatch error in Qdrant.

Solution

Added the codestral-embed model configuration to the openai-compatible provider section in embeddingModels.ts with the correct 3072 dimension support.

Changes

  • Added codestral-embed model to the openai-compatible provider with dimension: 3072 and scoreThreshold: 0.4
  • Added comprehensive test coverage in embeddingModels.spec.ts to ensure the model configuration works correctly

Testing

  • All existing tests pass
  • New tests added to verify the model configuration
  • Tested with service-factory and config-manager test suites

Fixes #6141


Important

Fixes issue #6141 by adding codestral-embed model support with 3072 dimensions to the OpenAI-compatible provider and adds tests for verification.

  • Behavior:
  • Testing:
    • Adds tests in embeddingModels.spec.ts to verify codestral-embed configuration for openai-compatible and mistral providers.
    • Tests getModelDimension() for correct dimension retrieval.
  • Misc:
    • Ensures all existing tests pass and adds new tests for model configuration verification.

This description was created by Ellipsis for 34e67cf. You can customize this summary. It will automatically update as commits are pushed.

@roomote roomote bot requested review from cte, jr and mrubens as code owners July 23, 2025 22:43
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Jul 23, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 23, 2025
@daniel-lxs
Copy link
Member

Not a fix at all, the issue might not have enough information

@daniel-lxs daniel-lxs closed this Jul 24, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 24, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

codestral-embed: Fails with 3072 dimensions via OpenAI-compatible provider

4 participants