Skip to content

Conversation

@psv2522
Copy link
Contributor

@psv2522 psv2522 commented Jan 28, 2025

Description

Use Dropdown from vscui instead of select in some settings dropdowns for more UI consistency

Type of change

UI

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

image
image

Related Issues

Reviewers


Important

Replaced select elements with Dropdown components from vscrui in ApiConfigManager.tsx and SettingsView.tsx for UI consistency.

  • UI Changes:
    • Replace select with Dropdown from vscrui in ApiConfigManager.tsx for configuration profile selection.
    • Replace select with Dropdown from vscrui in SettingsView.tsx for browser viewport size selection.

This description was created by Ellipsis for db0339b. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 7e38e50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samhvw8
Copy link
Contributor

samhvw8 commented Jan 28, 2025

love this, current @vscode/webview-ui-toolkit is sunset and has alot of bug, i trying to migrate to vscui too

@mrubens mrubens merged commit a968cc3 into RooCodeInc:main Jan 29, 2025
4 checks passed
@mrubens
Copy link
Collaborator

mrubens commented Jan 29, 2025

@psv2522 @samhvw8 I just realized there's some sort of z-index issue where these dropdowns are going behind the select box. Any ideas the best way to fix? Thank you!

Screenshot 2025-01-29 at 12 13 02 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants