fix: improve MCP tool error handling with retry logic and better messages #6191
+171
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages - Add retry logic with exponential backoff (up to 3 retries) for transient failures - Implement comprehensive error handling with user-friendly messages - Add parameter validation before MCP tool execution - Enhance error messages to provide actionable guidance - Check server connection status before attempting tool calls - Add localized error messages for better user experience Fixes #6189
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| if (!serverName) { | ||
| cline.consecutiveMistakeCount++ | ||
| cline.recordToolError("use_mcp_tool") | ||
| await cline.say("error", "Server name cannot be empty or contain only whitespace") |
Contributor
There was a problem hiding this comment.
Consider using the translation function (t) for user‐facing error messages instead of hardcoding strings (e.g. 'Server name cannot be empty or contain only whitespace'). This will ensure consistency with i18n practices.
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| if (!toolName) { | ||
| cline.consecutiveMistakeCount++ | ||
| cline.recordToolError("use_mcp_tool") | ||
| await cline.say("error", "Tool name cannot be empty or contain only whitespace") |
Contributor
There was a problem hiding this comment.
Similarly, use i18n for the tool name error message rather than a literal string.
Suggested change
| await cline.say("error", "Tool name cannot be empty or contain only whitespace") | |
| await cline.say("error", t("tool_name_empty_error")) |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
hannesrudolph
added
the
Issue/PR - Triage
Member
|
Not an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #6189 where users were experiencing consistent failures when using the Memory Bank MCP tool, causing Roo to stop working.
Changes
1. Retry Logic with Exponential Backoff
2. Enhanced Error Handling
3. Parameter Validation
4. Better User Experience
Testing
Impact
These changes should significantly improve the reliability of MCP tool execution and provide users with clearer guidance when issues occur, preventing the "Roo stops working" scenario described in the issue.
Fixes #6189
Important
Enhances MCP tool error handling with retry logic, improved messages, and parameter validation, significantly improving reliability and user guidance.
executeToolAndProcessResult()inuseMcpToolTool.tsfor transient MCP tool failures.callTool()inMcpHub.tswith detailed error categorization and improved messages.validateParams()inuseMcpToolTool.ts, trimming whitespace and checking JSON format.mcp.jsonfor better internationalization support.useMcpToolTool.spec.tsandMcpHub.spec.tsto match new error message formats and retry logic.This description was created by
for 1a1fc31. You can customize this summary. It will automatically update as commits are pushed.