Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jul 25, 2025

This PR fixes the issues identified in PR #6176 which adds an Export option to the slash command menu.

Issues Fixed:

  1. Missing Internationalization (i18n) - Replaced hardcoded English strings with proper translation keys
  2. No Test Coverage - Added comprehensive tests for the Export option functionality
  3. Pattern Inconsistencies - Consolidated duplicate icon rendering logic in ContextMenu.tsx

All tests pass successfully.

Fixes issues in PR #6176


Important

Fixes export option issues by adding i18n, tests, and consolidating logic in context menu.

  • Behavior:
    • Adds internationalization for export option in ContextMenu.tsx using useAppTranslation.
    • Handles export action in ChatTextArea.tsx by posting exportMode message with current mode.
    • Ensures export option is always included in context menu for slash commands in context-mentions.ts.
  • Tests:
    • Adds tests for export functionality in ChatTextArea.spec.tsx.
    • Tests context menu options including export in context-mentions.spec.ts.
  • Misc:
    • Consolidates icon rendering logic in ContextMenu.tsx.
    • Updates chat.json for new translation keys.

This description was created by Ellipsis for 5ad4d25. You can customize this summary. It will automatically update as commits are pushed.

roomote added 2 commits July 24, 2025 16:10
- Added Export as a new ContextMenuOptionType
- Modified getContextMenuOptions to include Export option at the top when "/" is typed
- Updated ContextMenu component to render Export option with appropriate icon
- Modified ChatTextArea to handle Export selection and trigger exportMode message
- Export option triggers the same action as the export button in mode settings
- Add missing i18n translations for Export option labels
- Replace hardcoded strings with translation keys
- Consolidate duplicate icon rendering logic in ContextMenu
- Add comprehensive test coverage for Export functionality
- Update tests to match implementation behavior
@roomote roomote bot requested review from cte, jr and mrubens as code owners July 25, 2025 01:40
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Jul 25, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 25, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants