fix: add crash recovery and Windows-specific error handling #6259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add global error handlers for uncaught exceptions and promise rejections - Implement crash information persistence for recovery on restart - Add Windows-specific signal handlers (SIGTERM, SIGINT, exit) - Enhance ErrorBoundary component with user-friendly crash recovery UI - Add restart functionality from ErrorBoundary - Implement task state persistence during crashes - Add subtask recovery mechanism to restore parent task context - Integrate crash telemetry logging - Add Windows-specific crash detection and messaging Fixes #6257
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| {this.state.isRecovering ? ( | ||
| <> | ||
| <span className="codicon codicon-loading codicon-modifier-spin mr-2"></span> | ||
| {t("errorBoundary.restarting", "Restarting...")} |
Contributor
There was a problem hiding this comment.
Avoid using inline English fallback strings in translation calls (e.g. t('errorBoundary.restarting', 'Restarting...')). Instead, rely solely on translations defined in your i18n JSON to meet our i18n guidelines.
Suggested change
| {t("errorBoundary.restarting", "Restarting...")} | |
| {t("errorBoundary.restarting")} |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
| "restartVSCode": "Restart VS Code", | ||
| "reportIssue": "Report Issue", | ||
| "technicalDetails": "Technical Details", | ||
| "helpText": "If the problem persists, please" |
Contributor
There was a problem hiding this comment.
Typo/Incomplete text: The 'helpText' string reads 'If the problem persists, please'. Consider completing this sentence for clarity.
Suggested change
| "helpText": "If the problem persists, please" | |
| "helpText": "If the problem persists, please contact support." |
hannesrudolph
added
the
Issue/PR - Triage
Member
|
Closing, issue is not properly scoped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements comprehensive crash recovery mechanisms and Windows-specific error handling to address the frequent crashes reported in issue #6257.
Changes
🛡️ Global Error Handling
🪟 Windows-Specific Improvements
🔄 Crash Recovery Features
🎯 Subtask Recovery
Testing
Screenshots
The enhanced ErrorBoundary now shows:
Fixes #6257
Important
This PR adds crash recovery and Windows-specific error handling, enhancing global error handling, UI, and telemetry logging.
extension.ts.extension.ts.ErrorBoundarycomponent inErrorBoundary.tsxwith crash recovery UI.extension.ts.reloadWindowcase towebviewMessageHandlerinwebviewMessageHandler.ts.common.jsonwith new error boundary messages.This description was created by
for 6fd883d. You can customize this summary. It will automatically update as commits are pushed.