Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jul 27, 2025

Summary

This PR refactors the system prompt structure to incorporate best practices from Claude Code, focusing on:

  • Conciseness: Added explicit tone and style guidelines with examples showing how to respond briefly
  • Task Management: Enhanced todo list guidance with detailed examples
  • Code Conventions: Added section on following existing patterns and security practices

Changes

New Sections Added:

  1. Tone and Style - Emphasizes concise, direct responses with specific examples (e.g., "2+2" → "4")
  2. Proactiveness - Guides balanced action-taking without surprising users
  3. Following Conventions - Ensures code changes follow existing patterns and libraries
  4. Task Management - Enhanced with detailed examples of todo list usage

Structural Improvements:

  • Reorganized sections for better logical flow
  • Moved response style rules from Rules section to dedicated Tone and Style section
  • Removed redundant instructions that are now in specialized sections
  • Updated all affected test snapshots

Test Results

  • ✅ All prompt-related tests updated and passing
  • ✅ Linting passed
  • ✅ Type checking passed

Impact

This refactor will make Roo more concise in responses while maintaining helpfulness, better at managing complex tasks with todo lists, and more consistent in following project conventions.

Closes: Slack request to refactor system prompt using Claude Code guidelines


Important

Refactor system prompt to incorporate Claude Code best practices, adding new sections for tone, proactiveness, conventions, and task management, and updating test snapshots.

  • Behavior:
    • Refactors system prompt structure to incorporate Claude Code best practices, focusing on conciseness, task management, and code conventions.
    • Adds new sections for Tone and Style, Proactiveness, Following Conventions, and Task Management.
    • Reorganizes sections for better logical flow.
    • Moves response style rules from Rules section to dedicated Tone and Style section.
    • Removes redundant instructions now covered in specialized sections.
    • Updates all affected test snapshots.
  • Files:
    • Adds following-conventions.ts, proactiveness.ts, task-management.ts, and tone-and-style.ts in sections.
    • Updates index.ts to include new sections.
    • Modifies system.ts to integrate new sections into the prompt generation.
  • Misc:
    • Removes conversational restrictions from rules.ts.
    • Updates objective.ts to remove conversational restrictions.

This description was created by Ellipsis for a971128. You can customize this summary. It will automatically update as commits are pushed.

- Add new Tone and Style section emphasizing conciseness with examples
- Add Proactiveness section for balanced action-taking
- Add Following Conventions section for code style guidance
- Add enhanced Task Management section with detailed todo list examples
- Reorganize prompt sections for better flow
- Remove redundant rules that are now in dedicated sections
- Update tests to reflect new prompt structure
@roomote roomote bot requested review from cte, jr and mrubens as code owners July 27, 2025 02:35
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jul 27, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 27, 2025
Output text to communicate with the user; all text you output outside of tool use is displayed to the user. Only use tools to complete tasks. Never use tools like execute_command or code comments as means to communicate with the user during the session.
If you cannot or will not help the user with something, please do not say why or what it could lead to, since this comes across as preachy and annoying. Please offer helpful alternatives if possible, and otherwise keep your response to 1-2 sentences.
Only use emojis if the user explicitly requests it. Avoid using emojis in all communication unless asked.
IMPORTANT: Keep your responses short, since they will be displayed on a command line interface.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and probably more elsewhere) is super CLI-specific, we should look through these carefully.

@daniel-lxs daniel-lxs marked this pull request as draft July 29, 2025 18:00
@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Jul 29, 2025
@hannesrudolph hannesrudolph added PR - Draft / In Progress and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 29, 2025
@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Jul 30, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request PR - Draft / In Progress size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants