feat: add export and import buttons to mode selector popover #6318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added export button that exports the currently selected mode - Added import button that shows import dialog with project/global options - Added state management for import dialog and importing status - Added message handler for importModeResult - Reused existing export/import functionality from ModesView - Maintained consistent styling with existing UI
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| setOpen(false) | ||
| if (!isImporting) { | ||
| const selectedLevel = ( | ||
| document.querySelector( |
Contributor
There was a problem hiding this comment.
Consider using React state to track the selected import level instead of relying on document.querySelector. This will simplify state management and improve testability.
hannesrudolph
added
the
Issue/PR - Triage
roomote bot
pushed a commit
that referenced
this pull request
Jul 28, 2025
- Extract shared ImportModeDialog component to eliminate code duplication between ModeSelector and ModesView - Add comprehensive test coverage for export/import functionality in ModeSelector - Implement user-facing error notifications with auto-dismiss for import/export operations - Refactor ModeSelector by extracting ModeSelectorFooter component and useModeSelectorExportImport hook - Reduce component complexity and improve maintainability - Remove unused IconButton import Fixes all critical issues identified in PR #6318 review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds export and import functionality to the mode selector popover, allowing users to export the currently selected mode and import modes directly from the mode selection menu.
Changes Made
Implementation Details
exportModemessage type to trigger mode exportTesting
Important
Adds export and import buttons to
ModeSelectorpopover, enabling mode export and import with project/global options.codicon-export) to export the current mode usingexportModemessage type.codicon-import) to show import dialog with project/global options.importModeResultmessage handler.showImportDialogandisImportingstates inModeSelector.ModeSelectortests pass.This description was created by
for 956891b. You can customize this summary. It will automatically update as commits are pushed.