add gemini-cli

[simiroll]

Important

Add gemini-cli provider with OAuth authentication, updating validation, UI components, and internationalization.

• Behavior:
  • Adds gemini-cli provider using OAuth authentication, no API key needed.
  • Updates validateApiConfiguration() in validate.ts to skip API key validation for gemini-cli.
• UI Components:
  • Adds GeminiCli component in providers/GeminiCli.tsx for settings UI.
  • Updates ApiOptions.tsx to include gemini-cli in provider options.
• Internationalization:
  • Adds geminiCli related strings in multiple locale files for settings and validation messages.
• Misc:
  • Updates index.ts files to export GeminiCliHandler and include it in API handler logic.

^{This description was created by for 09cb66d. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Code Review Summary

I've reviewed this PR that adds Gemini CLI provider support with OAuth authentication. The implementation is well-structured and includes comprehensive internationalization, but there are some critical security and reliability issues that need to be addressed.

Critical Issues (Must Fix)

1. Security: Hardcoded OAuth credentials

File: src/api/providers/gemini-cli.ts lines 21-23
Issue: OAuth client ID and secret are hardcoded in source code, which is a security vulnerability.
Recommendation: Move these to environment variables or a secure configuration system.

2. Missing error handling for credential refresh

File: src/api/providers/gemini-cli.ts lines 86-88
Issue: The fs.writeFile operation lacks proper error handling when saving refreshed credentials.
Recommendation: Add try-catch around the file write operation to handle potential failures gracefully.

Important Suggestions (Should Consider)

3. Inconsistent error logging

File: src/api/providers/gemini-cli.ts lines 112-115
Issue: Multiple separate console.error calls make debugging harder.
Recommendation: Consolidate into a single structured log entry for better debugging experience.

4. Missing OAuth credentials validation

File: src/api/providers/gemini-cli.ts line 54
Issue: Code assumes JSON structure without validating required fields.
Recommendation: Add validation to ensure all required OAuth fields are present before proceeding.

5. Potential API overload in onboarding

File: src/api/providers/gemini-cli.ts lines 184-188
Issue: Fixed 2-second polling interval could overload the API.
Recommendation: Implement exponential backoff to reduce API load during onboarding.

Minor Improvements (Nice to Have)

6. Enhanced test coverage

File: src/api/providers/__tests__/gemini-cli.spec.ts
Suggestion: Add test cases for edge scenarios like malformed OAuth files and network timeouts.

7. Type safety improvement

File: src/api/providers/gemini-cli.ts line 29
Suggestion: Consider using a more strict interface for OAuth credentials instead of a loose object type.

Positive Aspects

✅ Excellent internationalization coverage - All UI strings are properly translated across multiple locales
✅ Comprehensive test suite - Good coverage of main functionality and error scenarios
✅ Proper integration - Well-integrated into existing provider system and UI components
✅ OAuth flow implementation - Correctly handles token refresh and project discovery
✅ Free tier support - Properly configured with $0 pricing for all models

Overall Assessment

This is a solid implementation that adds valuable functionality. The critical security issue with hardcoded credentials should be addressed before merging, along with the error handling improvements. The internationalization work is exemplary and the overall code structure follows the project's patterns well.