Skip to content

Update the auto-translate prompt #6430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025
Merged

Update the auto-translate prompt #6430

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ad7d1f
Update the auto-translate prompt
mrubens Jul 30, 2025
e061fe5
PR feedback
mrubens Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .roo/roomotes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ github_events:
- event: pull_request.opened
action:
name: general.task
prompt: "Check this pull request for any missing translations in the codebase. First, run the check-translations script using `node scripts/find-missing-translations.js` and carefully review its output for any missing translations. Then look for hardcoded strings that should be internationalized, but focus only on hardcoded strings that were added in this PR rather than existing strings. Verify that all UI text uses i18n functions, and ensure translation files are updated for all supported languages. If the script reports missing translations or you find other translation issues, use the translator mode to add them."
prompt: |
1. Run the script `node scripts/find-missing-translations.js` and carefully review its output for any missing translations.
Copy link
Contributor

@roomote roomote bot Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The YAML indentation here might cause parsing issues. With the | literal block scalar, the content should be indented consistently relative to the prompt: key. Could you verify this renders correctly when the YAML is parsed? The current indentation looks correct, but it's worth double-checking since YAML is sensitive to indentation.

Copy link
Contributor

@roomote roomote bot Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be helpful to add a validation step before running the script? Something like Verify the script exists at scripts/find-missing-translations.js before proceeding could provide better error messages if the script is missing.

2. If the script reports missing translations, switch into `translate` mode and add them in all supported languages.
3. If you've added new translations, commit and push them to the existing PR.
Copy link
Contributor

@roomote roomote bot Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, could we use imperative mood throughout? Step 3 uses you've while other steps use imperative commands. Consider changing to If new translations were added, commit and push them to the existing PR.

4. If you get a permission error trying to push to the PR just give up (i.e don't create a new PR instead).
- event: pull_request_review_comment.created
action:
name: github.pr.comment.respond