-
Notifications
You must be signed in to change notification settings - Fork 2.4k
chore(deps): update dependency @testing-library/jest-dom to v6.9.1 #6455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM - This is a clean dependency update that maintains compatibility and passes all tests.
Summary:
- Updates @testing-library/jest-dom from 6.6.3 to 6.6.4 (patch version)
- All 78 test files pass successfully (880 tests passed, 1 skipped)
- No breaking changes expected for this patch update
- Includes beneficial change from chalk to picocolors for better performance
This routine dependency update is safe to merge.
a4fab22 to
3e6d711
Compare
0f72c77 to
39e089f
Compare
ff28d17 to
94c5ca6
Compare
94c5ca6 to
ac628b5
Compare
ac628b5 to
a433c9b
Compare
a433c9b to
cf44d84
Compare
a4105f2 to
2582b28
Compare
598d59d to
3fbcf76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues that need attention in this update.
| '@testing-library/jest-dom': | ||
| specifier: ^6.6.3 | ||
| version: 6.6.3 | ||
| version: 6.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] The lockfile resolves @testing-library/jest-dom to 6.9.1, but the declared specifier remains ^6.6.3 in the importer. Consider bumping the package.json specifier to ^6.9.1 to reflect the intended minimum and keep the manifest aligned with the lockfile.
49f21d0 to
be6d612
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new issues found - all concerns already addressed in existing comments.
04cf9ff to
9eb099e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues that need attention in this update.
| '@testing-library/jest-dom': | ||
| specifier: ^6.6.3 | ||
| version: 6.6.3 | ||
| version: 6.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Manifest drift: lockfile resolves @testing-library/jest-dom to 6.9.1 while webview-ui/package.json still pins ^6.6.3. Please bump the manifest to ^6.9.1 so sources and lockfile stay in sync and to avoid accidental downgrades on fresh installs or lockfile refreshes.
9eb099e to
5cb4ad8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new issues found - all concerns already addressed in existing comments.
5cb4ad8 to
942ed29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new issues found - all concerns already addressed in existing comments.
942ed29 to
74a86b1
Compare
Review SummaryThis PR updates Issues to Resolve
The package.json should be updated to reflect the intended minimum version to keep sources and lockfile in sync. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. Please address the manifest drift issue: update webview-ui/package.json to specify ^6.9.1 instead of ^6.6.3 for @testing-library/jest-dom.
74a86b1 to
49b3cbb
Compare
This PR contains the following updates:
6.6.3->6.9.1Release Notes
testing-library/jest-dom (@testing-library/jest-dom)
v6.9.1Compare Source
Bug Fixes
Nodeerror (nodejs) (#707) (0ff8904)v6.9.0Compare Source
Features
v6.8.0Compare Source
Features
v6.7.0Compare Source
Features
v6.6.4Compare Source
Performance Improvements
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.