fix: resolve Claude CLI --system-prompt flag error by passing via stdin #6536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove --system-prompt command line argument for all platforms - Pass system prompt and messages together via stdin (like Windows) - Update tests to reflect unified stdin behavior across platforms - Fixes #6534 where Claude CLI was failing with exit code 1
dosubot
bot
added
size:M
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| const isWindows = os.platform() === "win32" | ||
|
|
||
| // Build args based on platform | ||
| // Build args - no longer passing system prompt as command line argument |
Contributor
Author
There was a problem hiding this comment.
The comment could be more descriptive about why we're making this change. Consider:
This would help future maintainers understand the reasoning behind this architectural decision.
| } else { | ||
| stdinData = JSON.stringify(messages) | ||
| } | ||
| // Pass both system prompt and messages via stdin for all platforms |
Contributor
Author
There was a problem hiding this comment.
These two comment lines could be consolidated for brevity:
| } | ||
|
|
||
| // On Windows, should NOT have --system-prompt in args | ||
| // Should NOT have --system-prompt in args |
Contributor
Author
There was a problem hiding this comment.
This comment references Windows-specific behavior that no longer exists. Could we update it to reflect the unified behavior?
| } | ||
|
|
||
| // On non-Windows, should have --system-prompt in args | ||
| // Should NOT have --system-prompt in args (same behavior for all platforms now) |
Contributor
Author
There was a problem hiding this comment.
Same here - this comment still mentions platform differences that we've eliminated. Consider:
Member
|
Not a proper fix, issue is not scoped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6534
Problem
Users were experiencing "Command failed with exit code 1: claude -p --system-prompt" errors when using the Claude Code provider. The issue was that the Claude CLI was failing when the
--system-promptflag was passed as a command-line argument on non-Windows systems.Solution
--system-promptcommand line argument for all platformsTesting
Impact
This fix resolves the error that was preventing users from using the Claude Code provider when it would try to pass the system prompt as a command line flag.
Important
Fixes Claude CLI error by passing system prompt via stdin instead of command line argument, ensuring consistent behavior across platforms.
--system-promptcommand line argument inrun.ts.runProcess().run.spec.tsto verify stdin behavior for all platforms.--system-promptis not in args and stdin receives correct data.run.ts.This description was created by
for 5ed7692. You can customize this summary. It will automatically update as commits are pushed.