fix: prevent duplicate retry messages when API returns retry info #6542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check if error message already contains retry-related information - Avoid adding duplicate "Retry attempt X" and "Retrying in Y seconds" messages - Add test coverage for the scenario Fixes #6541
dosubot
bot
added
size:L
Closed
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
|
|
||
| // Check if the error message already contains retry-related information | ||
| // This prevents duplicate retry messages when the API itself returns retry information | ||
| const containsRetryInfo = /retry|retrying|attempt/i.test(errorMsg) |
Contributor
Author
There was a problem hiding this comment.
Is this regex pattern intentional? It could match partial words like 'country' containing 'retry'. Consider using word boundaries:
|
|
||
| // Check if the error message already contains retry-related information | ||
| // This prevents duplicate retry messages when the API itself returns retry information | ||
| const containsRetryInfo = /retry|retrying|attempt/i.test(errorMsg) |
Contributor
Author
There was a problem hiding this comment.
Could we extract this regex to a constant for better maintainability? Something like:
| const saySpy = vi.spyOn(cline, "say").mockResolvedValue(undefined) | ||
|
|
||
| // Create an error that already contains retry information | ||
| const mockError = new Error("Engine loop is not running. Retry attempt 1\nRetrying now...") |
Contributor
Author
There was a problem hiding this comment.
Great test coverage! Consider adding edge cases to make it even more robust:
- Error messages with 'retry' as part of another word (e.g., 'country')
- Multiple retry-related keywords in the same error
- Case sensitivity verification
This would ensure the regex behaves exactly as intended.
hannesrudolph
added
the
Issue/PR - Triage
Member
|
Closing, not an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where Roo Code was displaying duplicate retry messages when using OpenAI Compatible API providers that return errors already containing retry information.
Problem
When using certain API providers (like the Qwen3-235B-A22B model mentioned in the issue), the API itself returns error messages that contain retry-related text such as "Retry attempt 1" and "Retrying now...". Roo Code was then adding its own retry messages on top of these, creating confusing duplicate messages for users.
Solution
Testing
Fixes #6541
Important
Fixes duplicate retry messages in
Task.tsby checking for existing retry info in error messages and adjusts retry message logic accordingly.Task.ts, added regex check for retry-related info in error messages to prevent duplicate retry messages.should not duplicate retry messages when error already contains retry infoinTask.spec.ts.This description was created by
for c74d63d. You can customize this summary. It will automatically update as commits are pushed.