Fix: Restore comment consumption when clicking Save button #6551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified handlePrimaryButtonClick to always include text/images in askResponse - Ensures comments typed before clicking Save are properly consumed and sent to LLM - Fixes regression where comments were being ignored during file approval Fixes #6549
dosubot
bot
added
size:S
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| } else { | ||
| vscode.postMessage({ type: "askResponse", askResponse: "yesButtonClicked" }) | ||
| } | ||
| // Always send the message with text/images if they exist |
Contributor
Author
There was a problem hiding this comment.
Consider adding a test case to prevent future regressions. Specifically, a test that verifies comments are included in the askResponse when the Save button is clicked would help ensure this functionality doesn't break again.
| vscode.postMessage({ | ||
| type: "askResponse", | ||
| askResponse: "yesButtonClicked", | ||
| text: trimmedInput || undefined, |
Contributor
Author
There was a problem hiding this comment.
For consistency, consider using the same validation pattern for both text and images. Currently checking but only without a length check. Could we use:
| } else { | ||
| vscode.postMessage({ type: "askResponse", askResponse: "yesButtonClicked" }) | ||
| } | ||
| // Always send the message with text/images if they exist |
Contributor
Author
There was a problem hiding this comment.
The comment could be more specific about why we're always sending the message. Consider:
hannesrudolph
added
the
Issue/PR - Triage
Member
|
The check shouldn't interfere with sending actual string and images, closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6549
Summary
This PR restores the functionality where comments typed before clicking the Save button are properly consumed and sent to the LLM. This was a regression that prevented user comments from being included when approving file changes.
Changes
handlePrimaryButtonClickinChatView.tsxto always include text and images in theaskResponsemessageundefinedfor empty values instead of conditionally excluding themTesting
Impact
Users can once again add comments when approving file changes, which will be sent to the LLM for processing.
Important
Fixes regression in
ChatView.tsxto ensure comments are sent to LLM when Save is clicked, by always including text and images inaskResponse.handlePrimaryButtonClickinChatView.tsxto ensure comments are sent to LLM when Save is clicked.askResponsemessage, sendingundefinedfor empty values.This description was created by
for 0d0cab8. You can customize this summary. It will automatically update as commits are pushed.