Skip to content

Conversation

@samhvw8
Copy link
Contributor

@samhvw8 samhvw8 commented Jan 30, 2025

  • Add RequestyHandler implementation for API integration
  • Add RequestyModelPicker component for model selection
  • Update shared types and messages for Requesty support
  • Update API options to include Requesty provider

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Add support for Requesty API provider, including handler, model picker, and integration into existing API configuration and model management.

  • Behavior:
    • Add RequestyHandler in requesty.ts for API integration, supporting message creation and prompt completion.
    • Add RequestyModelPicker component for model selection in RequestyModelPicker.tsx.
    • Update ClineProvider.ts to handle Requesty models and API keys.
  • Models:
    • Add requestyDefaultModelId and requestyDefaultModelInfo to api.ts.
    • Add requestyModelInfoSaneDefaults to api.ts.
  • Tests:
    • Add tests for RequestyHandler in requesty.test.ts.
    • Update checkExistApiConfig.test.ts to include requestyApiKey.
  • UI:
    • Update ApiOptions.tsx to include Requesty API options.
    • Add requestyModels handling in ExtensionStateContext.tsx.
  • Misc:
    • Update ExtensionMessage.ts and WebviewMessage.ts to support Requesty messages.

This description was created by Ellipsis for 3254ba502578e52c6b39707ddb25db6716561db6. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025

⚠️ No Changeset found

Latest commit: 2449c49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samhvw8 samhvw8 marked this pull request as draft January 30, 2025 11:59
@samhvw8 samhvw8 force-pushed the feat/roo-code-requesty-provider branch from ea9eb94 to 3254ba5 Compare January 30, 2025 18:53
@samhvw8 samhvw8 marked this pull request as ready for review January 30, 2025 18:54
@samhvw8 samhvw8 force-pushed the feat/roo-code-requesty-provider branch from 3254ba5 to 9070d48 Compare February 1, 2025 03:05
@samhvw8 samhvw8 requested a review from cte as a code owner February 1, 2025 03:05
@samhvw8 samhvw8 force-pushed the feat/roo-code-requesty-provider branch 4 times, most recently from da1a7a4 to 1418cfa Compare February 5, 2025 08:22
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should move this down below glamaDefaultModelInfo

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this z index need to be model specific?

Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny nitpicks but this looks good otherwise! @cte you have a PR somewhere to unify these model pickers right - how do you think we should sequence the merging?

@samhvw8
Copy link
Contributor Author

samhvw8 commented Feb 7, 2025

Two tiny nitpicks but this looks good otherwise! @cte you have a PR somewhere to unify these model pickers right - how do you think we should sequence the merging?

Yeah, we should merge PR from @cte first then i will update for comment in here :D

@mrubens
Copy link
Collaborator

mrubens commented Feb 8, 2025

Two tiny nitpicks but this looks good otherwise! @cte you have a PR somewhere to unify these model pickers right - how do you think we should sequence the merging?

Yeah, we should merge PR from @cte first then i will update for comment in here :D

Great, it's in! #848 (comment)

- Add RequestyHandler implementation for API integration
- Add RequestyModelPicker component for model selection
- Update shared types and messages for Requesty support
- Update API options to include Requesty provider
- Add OpenAiHandlerOptions interface for configuration
- Extract processUsageMetrics to base class for reuse
- Update RequestyHandler to extend OpenAiHandler
- Add proper type safety for metrics handling
- Clean up code duplication across handlers
@samhvw8 samhvw8 force-pushed the feat/roo-code-requesty-provider branch from c35ac8e to d6e55af Compare February 10, 2025 13:15
@samhvw8
Copy link
Contributor Author

samhvw8 commented Feb 10, 2025

@mrubens i update with @cte's model picker

@amazon1148
Copy link

If Requesty hasn't been merged in yet I'd like to see if we could test their fallback policies. Support gets a lot of asks regarding API timeouts.

https://discord.com/channels/1326908673489899560/1326908939509436489/1338529006466629692

https://www.loom.com/share/cf96bb85b2d046ba8f24748ba18b7cd1?sid=20b5b4dd-a7e5-4eee-9e1f-5fb3bb06d9af

@samhvw8
Copy link
Contributor Author

samhvw8 commented Feb 10, 2025

If Requesty hasn't been merged in yet I'd like to see if we could test their fallback policies. Support gets a lot of asks regarding API timeouts.

https://discord.com/channels/1326908673489899560/1326908939509436489/1338529006466629692

https://www.loom.com/share/cf96bb85b2d046ba8f24748ba18b7cd1?sid=20b5b4dd-a7e5-4eee-9e1f-5fb3bb06d9af

@amazon1148 can you test it with me ?

@mrubens
Copy link
Collaborator

mrubens commented Feb 10, 2025

I'm going to merge this into main, but happy to make more changes as a follow-up if necessary! Let me know.

@mrubens mrubens merged commit c78fbed into RooCodeInc:main Feb 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants