fix: handle paths outside cwd in RooProtectedController to prevent RangeError #6584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #6583 where the Roo extension crashes with a RangeError when RooProtectedController encounters paths outside the current working directory.
Problem
The
ignorelibrary expects paths to be relative to the project root and throws a RangeError when it receives paths that go outside the cwd (e.g., "../../.roo/rules"). This was causing the extension to crash.Solution
isWriteProtected()to detect paths that start with ".." (indicating they go outside the cwd)false(not protected) for such paths before passing them to the ignore libraryRooIgnoreControllerhandles similar casesTesting
Fixes #6583
Important
Fixes
RangeErrorinRooProtectedControllerby handling paths outside cwd inisWriteProtected()and adds tests to ensure stability.RangeErrorinRooProtectedControllerby handling paths outside cwd inisWriteProtected().falsefor paths starting with ".." to prevent crash.RooProtectedController.spec.tsto verify paths outside cwd are not protected and do not throw errors.This description was created by
for 1267d6f. You can customize this summary. It will automatically update as commits are pushed.