-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: reduce Gemini 2.5 Pro minimum thinking budget to 128 #6588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
27c9c2d
feat: reduce Gemini 2.5 Pro minimum thinking budget to 128
roomote 6dd2d52
fix: remove duplicate condition in Gemini 2.5 Pro model detection
roomote 2c6ccd0
feat: allow Gemini 2.5 Pro models to set min thinking tokens to 128 i…
roomote 1fa71fb
fix: remove non-existent gemini-25-pro model check
roomote File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ import { type ModelInfo, type ProviderSettings, ANTHROPIC_DEFAULT_MAX_TOKENS } f | |
| import { | ||
| DEFAULT_HYBRID_REASONING_MODEL_MAX_TOKENS, | ||
| DEFAULT_HYBRID_REASONING_MODEL_THINKING_TOKENS, | ||
| GEMINI_25_PRO_MIN_THINKING_TOKENS, | ||
| shouldUseReasoningBudget, | ||
| shouldUseReasoningEffort, | ||
| getModelMaxOutputTokens, | ||
|
|
@@ -90,18 +91,28 @@ export function getModelParams({ | |
| let reasoningEffort: ModelParams["reasoningEffort"] = undefined | ||
|
|
||
| if (shouldUseReasoningBudget({ model, settings })) { | ||
| // Check if this is a Gemini 2.5 Pro model | ||
| const isGemini25Pro = modelId.includes("gemini-2.5-pro") | ||
|
|
||
| // If `customMaxThinkingTokens` is not specified use the default. | ||
| reasoningBudget = customMaxThinkingTokens ?? DEFAULT_HYBRID_REASONING_MODEL_THINKING_TOKENS | ||
| // For Gemini 2.5 Pro, default to 128 instead of 8192 | ||
| const defaultThinkingTokens = isGemini25Pro | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we make this comment more explicit about why Gemini 2.5 Pro has a different default? Perhaps mention performance or cost considerations that led to this decision? |
||
| ? GEMINI_25_PRO_MIN_THINKING_TOKENS | ||
| : DEFAULT_HYBRID_REASONING_MODEL_THINKING_TOKENS | ||
| reasoningBudget = customMaxThinkingTokens ?? defaultThinkingTokens | ||
|
|
||
| // Reasoning cannot exceed 80% of the `maxTokens` value. | ||
| // maxTokens should always be defined for reasoning budget models, but add a guard just in case | ||
| if (maxTokens && reasoningBudget > Math.floor(maxTokens * 0.8)) { | ||
| reasoningBudget = Math.floor(maxTokens * 0.8) | ||
| } | ||
|
|
||
| // Reasoning cannot be less than 1024 tokens. | ||
| if (reasoningBudget < 1024) { | ||
| reasoningBudget = 1024 | ||
| // Reasoning cannot be less than minimum tokens. | ||
| // For Gemini 2.5 Pro models, the minimum is 128 tokens | ||
| // For other models, the minimum is 1024 tokens | ||
| const minThinkingTokens = isGemini25Pro ? GEMINI_25_PRO_MIN_THINKING_TOKENS : 1024 | ||
| if (reasoningBudget < minThinkingTokens) { | ||
| reasoningBudget = minThinkingTokens | ||
| } | ||
|
|
||
| // Let's assume that "Hybrid" reasoning models require a temperature of | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding test cases for model ID variations and edge cases: