Skip to content

Conversation

@choronz
Copy link

@choronz choronz commented Aug 4, 2025

Related GitHub Issue

Closes: #

Roo Code Task Context (Optional)

Description

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch


Important

Updates extension publishing workflow, modifies code index constants, and adds quantization config to Qdrant vector store.

  • Workflows:
    • Renames .github/workflows/marketplace-publish.yml to publish-extension.yml.
    • Changes trigger from pull_request to push in publish-extension.yml.
  • Configurations:
    • Updates Node.js version requirement to 22.17.0 in package.json.
  • Constants:
    • Updates MAX_LIST_FILES_LIMIT_CODE_INDEX to 10,000 and BATCH_SEGMENT_THRESHOLD to 8 in constants/index.ts.
    • Adjusts MAX_BATCH_RETRIES to 5 and INITIAL_RETRY_DELAY_MS to 600 in constants/index.ts.
    • Changes MAX_ITEM_TOKENS to 2048 in constants/index.ts.
  • Vector Store:
    • Adds quantization_config to QdrantVectorStore in qdrant-client.ts.

This description was created by Ellipsis for 0cdb466. You can customize this summary. It will automatically update as commits are pushed.

@choronz choronz requested review from cte, jr and mrubens as code owners August 4, 2025 18:36
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 4, 2025
Copy link
Author

@choronz choronz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

export const MIN_CHUNK_REMAINDER_CHARS = 200 // Minimum characters for the *next* chunk after a split
export const MAX_CHARS_TOLERANCE_FACTOR = 1.15 // 15% tolerance for max chars

<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict markers (<<<<<<<, =======, >>>>>>>) remain in the file. Remove these and decide on the correct value for MAX_CHARS_TOLERANCE_FACTOR.

export const MAX_LIST_FILES_LIMIT_CODE_INDEX = 50_000
export const BATCH_SEGMENT_THRESHOLD = 60 // Number of code segments to batch for embeddings/upserts
export const MAX_LIST_FILES_LIMIT_CODE_INDEX = 10_000
export const BATCH_SEGMENT_THRESHOLD = 8 // 60 Number of code segments to batch for embeddings/upserts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BATCH_SEGMENT_THRESHOLD is set to 8 but the comment still indicates '60 Number of code segments'. Update the comment to accurately reflect the current threshold.

Suggested change
export const BATCH_SEGMENT_THRESHOLD = 8 // 60 Number of code segments to batch for embeddings/upserts
export const BATCH_SEGMENT_THRESHOLD = 8 // 8 Number of code segments to batch for embeddings/upserts

@choronz choronz closed this Aug 4, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Aug 4, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 4, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and found several critical issues that need attention before this can be merged.

Critical Issues (Must Fix):

  1. Missing PR Documentation: The PR template is not filled out - there's no linked issue, no description of changes, and no test procedure. This makes it difficult to understand the purpose and impact of these changes.

  2. Workflow Breaking Change (.github/workflows/publish-extension.yml):

    • The trigger was changed from pull_request to push, but the job conditions still check for github.event_name == 'pull_request'. This creates an impossible condition where the workflow will never run.
    • The actual publishing step has been completely removed. Without it, this workflow only packages and tags but doesn't actually publish to the marketplace.
  3. Performance Impact Without Justification (src/services/code-index/constants/index.ts):

    • MAX_LIST_FILES_LIMIT_CODE_INDEX: 50,000 → 10,000 (80% reduction)
    • BATCH_SEGMENT_THRESHOLD: 60 → 8 (87% reduction)
    • MAX_BATCH_TOKENS: 100,000 → 16,384 (84% reduction)
    • MAX_ITEM_TOKENS: 8,191 → 2,048 (75% reduction)

    These changes could severely impact performance for users with large codebases.

Important Suggestions (Should Consider):

  1. Node.js Major Version Upgrade (package.json): Upgrading from Node.js 20.19.2 to 22.17.0 is a major version change that could introduce breaking changes. Has this been tested across all environments?

  2. Quantization Configuration (src/services/code-index/vector-store/qdrant-client.ts): Adding binary quantization without context about why this is needed or what performance/accuracy trade-offs were considered.

  3. Confusing Code Comment: Line 6 in constants/index.ts has "8% 15 tolerance" which appears to be a typo.

Please address these issues and provide context for these significant changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant