Skip to content

Conversation

@QuinsZouls
Copy link
Contributor

@QuinsZouls QuinsZouls commented Aug 4, 2025

Related GitHub Issue

Closes: #6632

Roo Code Task Context (Optional)

Description

On linux host , there's a change that opening a chromium browser with sandbox enabled cause the browser can't reach the target url because network related error:

/.config/Code/User/globalStorage/rooveterinaryinc.roo-cline/puppeteer/.chromium-browser-snapshots/chromium/linux-1454799/chrome-linux/chrome  --headless --dump-dom https://daisyui.com/llms.txt
WARNING: radv is not a conformant Vulkan implementation, testing use only.
[39715:6:0804/142722.158245:ERROR:gpu/ipc/client/command_buffer_proxy_impl.cc:127] ContextResult::kTransientFailure: Failed to send GpuControl.CreateCommandBuffer.
[39618:39618:0804/142727.517672:ERROR:content/browser/network_service_instance_impl.cc:606] Network service crashed, restarting service.
[39618:39618:0804/142733.299365:ERROR:content/browser/network_service_instance_impl.cc:606] Network service crashed, restarting service.
[39618:39618:0804/142737.479671:ERROR:content/browser/network_service_instance_impl.cc:606] Network service crashed, restarting service.

Adding the arg --no-sandbox solve this issue, ref: puppeteer/puppeteer#8246

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch


Important

Add --no-sandbox flag to UrlContentFetcher.ts to fix network errors on Linux hosts.

  • Behavior:
    • Add --no-sandbox flag to browser launch options in UrlContentFetcher.ts to fix network errors on Linux hosts.
  • Context:

This description was created by Ellipsis for 9221f57. You can customize this summary. It will automatically update as commits are pushed.

@QuinsZouls QuinsZouls requested review from cte, jr and mrubens as code owners August 4, 2025 20:41
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Aug 4, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and have some suggestions for improvement, particularly around security considerations and test coverage.

@roomote
Copy link
Contributor

roomote bot commented Aug 4, 2025

I also noticed that the test file src/services/browser/__tests__/UrlContentFetcher.spec.ts would need to be updated to verify the new --no-sandbox flag is included in the browser launch arguments. The test on lines 137-146 currently checks for other flags but doesn't include this new one.

Additionally, it might be worth exploring if we can detect when we're running in a container or restricted environment and only apply this flag in those cases, rather than applying it universally.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 4, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 4, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Aug 6, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Aug 6, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @QuinsZouls

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 11, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Aug 11, 2025
@mrubens mrubens merged commit b6dd6e5 into RooCodeInc:main Aug 12, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 12, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Error fetching url content

4 participants