-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: add --no-sandbox flag to browser launch options #6686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add --no-sandbox flag to browser launch options #6686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I've reviewed the changes and have some suggestions for improvement, particularly around security considerations and test coverage.
|
I also noticed that the test file Additionally, it might be worth exploring if we can detect when we're running in a container or restricted environment and only apply this flag in those cases, rather than applying it universally. |
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @QuinsZouls
Related GitHub Issue
Closes: #6632
Roo Code Task Context (Optional)
Description
On linux host , there's a change that opening a chromium browser with sandbox enabled cause the browser can't reach the target url because network related error:
Adding the arg --no-sandbox solve this issue, ref: puppeteer/puppeteer#8246
Test Procedure
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Add
--no-sandboxflag toUrlContentFetcher.tsto fix network errors on Linux hosts.--no-sandboxflag to browser launch options inUrlContentFetcher.tsto fix network errors on Linux hosts.This description was created by
for 9221f57. You can customize this summary. It will automatically update as commits are pushed.