feat: implement stable project ID feature (Sprint 1) #6688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add project ID utility functions (getProjectId, generateProjectId, hasProjectId) - Include project ID in task history metadata - Update getTaskWithId to support searching by project ID - Add "Generate Project ID" VSCode command - Add comprehensive unit tests This implements the core functionality for stable project IDs that persist across different project locations. Users can now generate a unique project ID that will be stored in a .rooprojectid file. Part of #6618
dosubot
bot
added
size:L
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| vscode.window.showInformationMessage(t("projectId.generated")) | ||
| } catch (error) { | ||
| outputChannel.appendLine(`Error generating project ID: ${error}`) | ||
| vscode.window.showErrorMessage(t("projectId.generateError", { error: String(error) })) |
Contributor
Author
There was a problem hiding this comment.
Consider adding telemetry or metrics here to track how often project ID generation fails. This could help identify common issues users face.
|
|
||
| // If not found by ID and the ID looks like a project ID (UUID format), | ||
| // try to find by project ID | ||
| if (!historyItem && id.match(/^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i)) { |
Contributor
Author
There was a problem hiding this comment.
This UUID regex pattern appears twice in this file (lines 1376 and 1376). Consider extracting it to a constant like for reusability and consistency.
| expect(fileExistsAtPath).toHaveBeenCalledWith(projectIdPath) | ||
| }) | ||
| }) | ||
| }) |
Contributor
Author
There was a problem hiding this comment.
Consider adding test cases for:
- Concurrent project ID generation attempts
- File system permission errors
- Race conditions when multiple VSCode instances try to create the same project ID
| import { v4 as uuidv4 } from "uuid" | ||
| import { fileExistsAtPath } from "./fs" | ||
|
|
||
| const PROJECT_ID_FILENAME = ".rooprojectid" |
Contributor
Author
There was a problem hiding this comment.
The file format and purpose could be documented in a README or contributing guide. Also, consider adding a comment here indicating that migration logic will be added in Sprint 2.
hannesrudolph
added
the
Issue/PR - Triage
Member
|
The issue hasn't been approved or scoped yet, closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the core functionality for stable project IDs that persist across different project locations.
What this PR does
Sprint 1: Core Project ID Logic & Foundational Commands
Task 1.1: Implement Project ID Utility
src/utils/projectId.tswith three core functions:getProjectId()- Reads project ID from.rooprojectidfilegenerateProjectId()- Generates and saves a new UUID project IDhasProjectId()- Checks if a project has an ID fileTask 1.2: Modify History Key Generation
src/core/task-persistence/taskMetadata.tsto include project ID in history itemssrc/core/webview/ClineProvider.tsto support searching tasks by project IDHistoryItemtype inpackages/types/src/history.tsto include optionalprojectIdfieldTask 1.3: Create "Generate Project ID" Command
generateProjectIdto the command list inpackages/types/src/vscode.tssrc/activate/registerCommands.tssrc/package.jsonandsrc/package.nls.jsonsrc/i18n/locales/en/common.jsonTesting
src/utils/__tests__/projectId.spec.tsHow to test
.rooprojectidfile is created in the project rootNext steps
This is Sprint 1 of 3. Future sprints will add:
Fixes #6618
Important
Implement stable project ID feature with utility functions, command, and task history integration.
getProjectId(),generateProjectId(), andhasProjectId()insrc/utils/projectId.tsto manage project IDs.taskMetadata()intaskMetadata.tsto includeprojectIdinHistoryItem.ClineProviderinClineProvider.tsto search tasks byprojectId.generateProjectIdcommand inregisterCommands.tsandpackage.json.registerCommands.ts.projectId.spec.tsfor project ID utilities.common.json.This description was created by
for 72e6abf. You can customize this summary. It will automatically update as commits are pushed.