Skip to content

feat: focus chat input when clicking plus button in extension menu #6689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
+3 −0
Merged

feat: focus chat input when clicking plus button in extension menu #6689

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f054a7
feat: focus chat input when clicking plus button in extension menu
roomote Aug 4, 2025
ebde2c2
fix: replace unreliable setTimeout with sequential message passing
roomote Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/activate/registerCommands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ const getCommandsMap = ({ context, outputChannel, provider }: RegisterCommandOpt
await visibleProvider.removeClineFromStack()
await visibleProvider.postStateToWebview()
await visibleProvider.postMessageToWebview({ type: "action", action: "chatButtonClicked" })

// Focus the input after a short delay to ensure the view has switched
setTimeout(() => {
Copy link
Contributor Author

@roomote roomote bot Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this 100ms delay intentional? While it works in most cases, slower machines or heavy load could cause the ChatView to take longer than 100ms to render, making the focus attempt fail silently. Could we consider using a more robust approach like a callback or event-based mechanism to ensure the view is ready?

visibleProvider.postMessageToWebview({ type: "action", action: "focusInput" })
Copy link
Contributor Author

@roomote roomote bot Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice there's already a command (lines 198-209) that handles focus differently for sidebar vs tab panels. Could we consider reusing that existing command for consistency? It already has error handling and panel-specific logic.

}, 100)
Copy link
Contributor Author

@roomote roomote bot Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider extracting this magic number to a named constant with a comment explaining why 100ms was chosen. Something like:

},
mcpButtonClicked: () => {
const visibleProvider = getVisibleProviderOrLog(outputChannel)
Expand Down
Loading