Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jan 31, 2025

I'm nervous about the lint rules confusing the agent, so reverting for now. Let's discuss more!


Important

Reverts ESLint configuration and lint script changes to previous state due to concerns about agent confusion.

  • Revert Changes:
    • Reverts ESLint configuration in .eslintrc.json to previous state, removing extended rules and plugins.
    • Reverts lint script in package.json and webview-ui/package.json to remove --quiet flag.

This description was created by Ellipsis for 810bbb4. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 810bbb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

"ecmaVersion": 2021,
"sourceType": "module",
"project": "./tsconfig.json"
"ecmaVersion": 6,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ecmaVersion is set to 6, which is outdated. It should be updated to a more recent version, like 2021, to support modern JavaScript features. This is in line with our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d58180f3b596d34d01891cb5

@mrubens mrubens merged commit a10bb20 into main Jan 31, 2025
6 checks passed
@mrubens mrubens deleted the revert_lint_changes branch January 31, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants