feat: allow users to change mode when approving orchestrator subtasks #6708

roomote · 2025-08-05T09:35:54Z

This PR implements the feature requested in #6706 to allow users to change the mode when the orchestrator requests to create a subtask.

Changes Made

Frontend (webview-ui)

ChatRow.tsx: Modified to render a ModeSelector component instead of static mode text for newTask tools
ChatView.tsx: Added state management to track mode selections by message timestamp and pass the selected mode when approving
Translation: Added selectMode key to the English translation file for the mode selector tooltip

Backend (src)

Task.ts:
- Modified handleWebviewAskResponse to accept and store values parameter
- Added askResponseValues property and getAskResponseValues getter method
newTaskTool.ts: Updated to check for user-selected mode in askResponseValues and use it instead of the original mode parameter

Tests

Added comprehensive tests in newTaskTool.spec.ts to verify:
- Tool uses user-selected mode when provided
- Falls back to original mode when no selection is made
- Handles invalid mode selections gracefully

How It Works

When the orchestrator shows a newTask approval, the mode is now clickable
Users can select a different mode from the dropdown before approving
The selected mode is passed through the askResponse flow via the values field
The newTaskTool checks for a user-selected mode and uses it to create the subtask

Testing

All existing tests pass, and new tests have been added to cover the new functionality.

Fixes #6706

Important

Allows users to change mode when approving orchestrator subtasks, with frontend and backend updates and new tests.

Frontend (webview-ui):
- ChatRow.tsx: Replaces static mode text with ModeSelector for newTask tools.
- ChatView.tsx: Manages state for mode selections by timestamp and passes selected mode on approval.
- Adds selectMode key to English translation for mode selector tooltip.
Backend (src):
- Task.ts: Modifies handleWebviewAskResponse to accept values parameter; adds askResponseValues property and getAskResponseValues getter.
- newTaskTool.ts: Checks for user-selected mode in askResponseValues and uses it instead of original mode.
Tests:
- Adds tests in newTaskTool.spec.ts to verify user-selected mode usage, fallback to original mode, and handling of invalid selections.

^{This description was created by}^{for 8bedb73. You can customize this summary. It will automatically update as commits are pushed.}

- Added ModeSelector component to newTask tool approval UI in ChatRow - Users can now click on the mode to select a different one before approving - Selected mode is passed through the askResponse flow to the backend - Modified Task.ts to store and provide access to askResponseValues - Updated newTaskTool.ts to use the user-selected mode if provided - Added comprehensive tests for the new functionality - Added translation key for mode selector tooltip Fixes #6706

roomote

I reviewed my own code and found it acceptable. The bar was low.

roomote · 2025-08-05T09:40:37Z

webview-ui/src/components/chat/ChatView.tsx

+												onClick={() => {
+													// Check if this is a newTask tool and we have a selected mode
+													let additionalData = undefined
+													if (lastMessage?.ask === "tool") {


Is this the best way to handle the type checking? The try-catch for JSON parsing works, but we could extract this logic into a helper function for better reusability and type safety.

Also, I notice the state grows unbounded as messages accumulate. Should we consider cleaning up old entries when tasks complete to prevent potential memory issues in long-running sessions?

roomote · 2025-08-05T09:40:38Z

src/core/task/Task.ts

 	public lastMessageTs?: number

+	// Getter for askResponseValues to allow tools to access it
+	get getAskResponseValues(): Record<string, any> | undefined {


Nice addition of the getter! Consider adding a JSDoc comment to document what this getter returns and when it's used. This would help future maintainers understand the askResponseValues flow better.

roomote · 2025-08-05T09:40:38Z

webview-ui/src/components/chat/ChatRow.tsx

+							<span style={{ fontWeight: "bold", display: "flex", alignItems: "center", gap: "4px" }}>
+								{t("chat:subtasks.wantsToCreate").split("{mode}")[0]}
+								{message.type === "ask" ? (
+									<ModeSelector


The mode selector integration looks clean! A small UI enhancement to consider: when in "ask" state, the current mode could be shown more prominently to help users understand what they're changing from.

roomote · 2025-08-05T09:40:38Z

src/core/tools/__tests__/newTaskTool.spec.ts


 	// Add more tests for error handling (missing params, invalid mode, approval denied) if needed
+
+	it("should use user-selected mode when provided in askResponseValues", async () => {


Great test coverage! The edge cases are well handled. Consider adding an integration test that verifies the full flow from UI interaction to task creation with the selected mode - this would give us confidence that all the pieces work together correctly.

roomote

I reviewed my own code and found it acceptable. The bar was low.

roomote · 2025-08-05T09:41:00Z

webview-ui/src/components/chat/ChatView.tsx

+												onClick={() => {
+													// Check if this is a newTask tool and we have a selected mode
+													let additionalData = undefined
+													if (lastMessage?.ask === "tool") {


Is this the best way to handle the type checking? The try-catch for JSON parsing works, but we could extract this logic into a helper function for better reusability and type safety.

Also, I notice the selectedNewTaskModes state grows unbounded as messages accumulate. Should we consider cleaning up old entries when tasks complete to prevent potential memory issues in long-running sessions?

roomote · 2025-08-05T09:41:00Z

src/core/task/Task.ts

 	public lastMessageTs?: number

+	// Getter for askResponseValues to allow tools to access it
+	get getAskResponseValues(): Record<string, any> | undefined {


Nice addition of the getter! Consider adding a JSDoc comment to document what this getter returns and when it's used. This would help future maintainers understand the askResponseValues flow better.

roomote · 2025-08-05T09:41:00Z

webview-ui/src/components/chat/ChatRow.tsx

+							<span style={{ fontWeight: "bold", display: "flex", alignItems: "center", gap: "4px" }}>
+								{t("chat:subtasks.wantsToCreate").split("{mode}")[0]}
+								{message.type === "ask" ? (
+									<ModeSelector


The mode selector integration looks clean! A small UI enhancement to consider: when in "ask" state, the current mode could be shown more prominently to help users understand what they're changing from.

roomote · 2025-08-05T09:41:01Z

src/core/tools/__tests__/newTaskTool.spec.ts


 	// Add more tests for error handling (missing params, invalid mode, approval denied) if needed
+
+	it("should use user-selected mode when provided in askResponseValues", async () => {


Great test coverage! The edge cases are well handled. Consider adding an integration test that verifies the full flow from UI interaction to task creation with the selected mode - this would give us confidence that all the pieces work together correctly.

ellipsis-dev · 2025-08-05T09:48:40Z

webview-ui/src/i18n/locales/de/chat.json

 		"defaultResult": "Bitte fahre mit der nächsten Aufgabe fort.",
-		"completionInstructions": "Teilaufgabe abgeschlossen! Du kannst die Ergebnisse überprüfen und Korrekturen oder nächste Schritte vorschlagen. Wenn alles gut aussieht, bestätige, um das Ergebnis an die übergeordnete Aufgabe zurückzugeben."
+		"completionInstructions": "Teilaufgabe abgeschlossen! Du kannst die Ergebnisse überprüfen und Korrekturen oder nächste Schritte vorschlagen. Wenn alles gut aussieht, bestätige, um das Ergebnis an die übergeordnete Aufgabe zurückzugeben.",
+		"selectMode": "Klicken Sie, um einen anderen Modus für diese Unteraufgabe auszuwählen"


Typographical note: The translation uses "Unteraufgabe" in 'selectMode' while the other related keys (like 'completionContent' and 'resultContent') use "Teilaufgabe". Consider if this inconsistency is intentional, or if it should be standardized for clarity.

Suggested change

"selectMode": "Klicken Sie, um einen anderen Modus für diese Unteraufgabe auszuwählen"

"selectMode": "Klicken Sie, um einen anderen Modus für diese Teilaufgabe auszuwählen"

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

ellipsis-dev · 2025-08-05T09:48:40Z

webview-ui/src/i18n/locales/hi/chat.json

 		"defaultResult": "कृपया अगले कार्य पर जारी रखें।",
-		"completionInstructions": "उपकार्य पूर्ण! आप परिणामों की समीक्षा कर सकते हैं और सुधार या अगले चरण सुझा सकते हैं। यदि सब कुछ ठीक लगता है, तो मुख्य कार्य को परिणाम वापस करने के लिए पुष्टि करें।"
+		"completionInstructions": "उपकार्य पूर्ण! आप परिणामों की समीक्षा कर सकते हैं और सुधार या अगले चरण सुझा सकते हैं। यदि सब कुछ ठीक लगता है, तो मुख्य कार्य को परिणाम वापस करने के लिए पुष्टि करें।",
+		"selectMode": "इस उप-कार्य के लिए एक अलग मोड चुनने के लिए क्लिक करें"


Typographical consistency: The new string uses "उप-कार्य" with a hyphen, while other related keys (e.g., "completionContent") use "उपकार्य" without a hyphen. Consider using a consistent spelling for term across translations.

Suggested change

"selectMode": "इस उप-कार्य के लिए एक अलग मोड चुनने के लिए क्लिक करें"

"selectMode": "इस उपकार्य के लिए एक अलग मोड चुनने के लिए क्लिक करें"

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

ellipsis-dev · 2025-08-05T09:48:40Z

webview-ui/src/i18n/locales/it/chat.json

 		"defaultResult": "Per favore continua con la prossima attività.",
-		"completionInstructions": "Sottoattività completata! Puoi rivedere i risultati e suggerire correzioni o prossimi passi. Se tutto sembra a posto, conferma per restituire il risultato all'attività principale."
+		"completionInstructions": "Sottoattività completata! Puoi rivedere i risultati e suggerire correzioni o prossimi passi. Se tutto sembra a posto, conferma per restituire il risultato all'attività principale.",
+		"selectMode": "Clicca per selezionare una modalità diversa per questo sottocompito"


Typographical note: There's an inconsistency in the terminology used. Earlier strings use "sottoattività" (e.g., in 'completionContent' and 'resultContent'), but here "selectMode" uses "sottocompito". Consider using a consistent term across keys, unless this variation is intended.

Suggested change

"selectMode": "Clicca per selezionare una modalità diversa per questo sottocompito"

"selectMode": "Clicca per selezionare una modalità diversa per questa sottoattività"

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

ellipsis-dev · 2025-08-05T09:48:40Z

webview-ui/src/i18n/locales/zh-TW/chat.json

 		"defaultResult": "請繼續下一個工作。",
-		"completionInstructions": "子工作已完成！您可以檢閱結果並提出修正或下一步建議。如果一切看起來良好，請確認以將結果傳回主工作。"
+		"completionInstructions": "子工作已完成！您可以檢閱結果並提出修正或下一步建議。如果一切看起來良好，請確認以將結果傳回主工作。",
+		"selectMode": "點擊為此子任務選擇不同的模式"


Typographical note: The new key uses '子任務' while 'completionInstructions' uses '子工作'. Consider standardizing the terminology unless the distinction is intentional.

Suggested change

"selectMode": "點擊為此子任務選擇不同的模式"

"selectMode": "點擊為此子工作選擇不同的模式"

^{This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.}

daniel-lxs · 2025-08-12T17:34:22Z

This doesn't work properly, I'll close this and leave the issue unassigned in case anyone wants to work on it

roomote bot requested review from cte, jr and mrubens as code owners August 5, 2025 09:35

github-project-automation bot added this to Roo Code Roadmap Aug 5, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Aug 5, 2025

github-project-automation bot added this to Roo Code Roadmap Aug 5, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Aug 5, 2025

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Aug 5, 2025

roomote bot commented Aug 5, 2025

View reviewed changes

fix: add missing translations for subtasks.selectMode in all locales

8bedb73

hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 5, 2025

ellipsis-dev bot reviewed Aug 5, 2025

View reviewed changes

roomote bot mentioned this pull request Aug 5, 2025

[ENHANCEMENT] Orchestrator: choose subtask mode before approval #6706

Closed

daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Aug 6, 2025

hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Aug 6, 2025

daniel-lxs closed this Aug 12, 2025

github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 12, 2025

github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap Aug 12, 2025


		// Add more tests for error handling (missing params, invalid mode, approval denied) if needed

		it("should use user-selected mode when provided in askResponseValues", async () => {

	"selectMode": "Klicken Sie, um einen anderen Modus für diese Unteraufgabe auszuwählen"
	"selectMode": "Klicken Sie, um einen anderen Modus für diese Teilaufgabe auszuwählen"

	"selectMode": "इस उप-कार्य के लिए एक अलग मोड चुनने के लिए क्लिक करें"
	"selectMode": "इस उपकार्य के लिए एक अलग मोड चुनने के लिए क्लिक करें"

	"selectMode": "Clicca per selezionare una modalità diversa per questo sottocompito"
	"selectMode": "Clicca per selezionare una modalità diversa per questa sottoattività"

	"selectMode": "點擊為此子任務選擇不同的模式"
	"selectMode": "點擊為此子工作選擇不同的模式"

feat: allow users to change mode when approving orchestrator subtasks #6708

feat: allow users to change mode when approving orchestrator subtasks #6708

Uh oh!

Conversation

roomote bot commented Aug 5, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

Frontend (webview-ui)

Backend (src)

Tests

How It Works

Testing

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Uh oh!

roomote bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot left a comment

Choose a reason for hiding this comment

Uh oh!

roomote bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

roomote bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

ellipsis-dev bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

daniel-lxs commented Aug 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

roomote bot commented Aug 5, 2025 •

edited by ellipsis-dev bot

Loading