feat: add Cmd+R/Ctrl+R keyboard shortcut for new task #6719
Conversation
- Added keybinding configuration in package.json for roo-cline.newTask command - Created utility function to detect OS and format keyboard shortcuts - Updated ChatView.tsx to display keyboard shortcut in tooltip - Shortcut shows as ⌘R on Mac and Ctrl+R on Windows/Linux
dosubot
bot
added
size:M
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| @@ -0,0 +1,30 @@ | |||
| /** | |||
There was a problem hiding this comment.
This utility file needs unit tests to ensure the OS detection logic works correctly across different platforms. Could we add tests for Mac, Windows, and Linux detection?
| */ | ||
| export function getKeyboardShortcut(commandKey: string): string { | ||
| // Check if we're on macOS | ||
| const isMac = |
There was a problem hiding this comment.
Is using both navigator.platform and navigator.userAgent intentional? Since navigator.platform is deprecated, we might want to consider using navigator.userAgentData when available:
| const isMac = | |
| const isMac = navigator.userAgentData?.platform === 'macOS' || | |
| navigator.platform.toUpperCase().indexOf("MAC") >= 0 || navigator.userAgent.toUpperCase().indexOf("MAC") >= 0 |
| ? t("chat:runCommand.tooltip") | ||
| : primaryButtonText === t("chat:startNewTask.title") | ||
| ? t("chat:startNewTask.tooltip") | ||
| ? `${t("chat:startNewTask.tooltip")} (${getNewTaskShortcut()})` |
There was a problem hiding this comment.
For better accessibility, could we consider adding an aria-label that includes the keyboard shortcut? This would help screen reader users know about the shortcut when the button receives focus.
| * Utility functions for handling keyboard shortcuts | ||
| */ | ||
|
|
||
| /** |
There was a problem hiding this comment.
Could we add a JSDoc comment explaining that this function respects keyboard layouts? The current comment is good, but mentioning keyboard layout support would be helpful for future maintainers.
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
|
This is already possible with the native VSCode keybinds: |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
This PR adds a keyboard shortcut (Cmd+R on Mac, Ctrl+R on Windows/Linux) to open the new task panel in the VSCode extension.
Changes Made
src/package.jsonfor theroo-cline.newTaskcommandwebview-ui/src/utils/keyboardShortcuts.tsto detect OS and format keyboard shortcuts appropriatelyChatView.tsxto display the keyboard shortcut in the "Start New Task" button tooltipNotes
Testing
Important
Adds Cmd+R/Ctrl+R shortcut to open new task panel in VSCode extension, with OS-specific formatting and UI tooltip updates.
roo-cline.newTaskcommand keybinding insrc/package.json.getKeyboardShortcut()andgetNewTaskShortcut()inkeyboardShortcuts.tsto format shortcuts based on OS.ChatView.tsxto show shortcut in "Start New Task" button tooltip.This description was created by
for 476eaa0. You can customize this summary. It will automatically update as commits are pushed.