fix: override Kimi-K2 context window to 131K to match OpenRouter advertised specs #6760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtised specs - OpenRouter API returns 63K for moonshotai/kimi-k2 but their website shows 131K - Added manual override in parseOpenRouterModel to set correct context window - Added test to verify the override works correctly Fixes #6759
dosubot
bot
added
size:M
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| // Should override to 131K (131072) instead of using the API's 63K | ||
| expect(result.contextWindow).toBe(131072) | ||
| // Max tokens should be calculated as 20% of context window | ||
| expect(result.maxTokens).toBe(Math.ceil(63000 * 0.2)) // Still uses original for maxTokens calculation |
Contributor
Author
There was a problem hiding this comment.
Is this intentional? The test comment mentions "Still uses original for maxTokens calculation", but it might be confusing that the context window is overridden to 131K while maxTokens remains based on the original 63K (20% of 63K = 12,600). Consider either:
- Using 20% of the new 131K context window for consistency
- Adding a comment in the implementation explaining why maxTokens uses the original value
| } | ||
|
|
||
| // Override kimi-k2 context window to match OpenRouter's advertised 131K | ||
| // The API returns 63K but the website shows 131K |
Contributor
Author
There was a problem hiding this comment.
Would it be helpful to add a link to the OpenRouter website page as a reference? For example:
Suggested change
| // The API returns 63K but the website shows 131K | |
| // Override kimi-k2 context window to match OpenRouter's advertised 131K | |
| // The API returns 63K but the website shows 131K | |
| // See: https://openrouter.ai/moonshotai/kimi-k2 |
|
|
||
| // Override kimi-k2 context window to match OpenRouter's advertised 131K | ||
| // The API returns 63K but the website shows 131K | ||
| if (id === "moonshotai/kimi-k2") { |
Contributor
Author
There was a problem hiding this comment.
Consider moving this override closer to other model-specific overrides (lines 236-248) for better code organization and consistency with the existing pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the context window discrepancy for the Kimi-K2 model in RooCode. While OpenRouter's API returns 63K for the context window, their website advertises 131K. This PR adds a manual override to ensure users get the full advertised context window.
Problem
context_length: 63000formoonshotai/kimi-k2Solution
parseOpenRouterModelfunction to set the context window to 131072 (131K) for themoonshotai/kimi-k2modelTesting
Fixes #6759
Important
Overrides
moonshotai/kimi-k2model context window to 131072 inparseOpenRouterModelto match advertised 131K, with a new test verifying the change.moonshotai/kimi-k2model context window to 131072 inparseOpenRouterModelto match advertised 131K.openrouter.spec.tsto verify context window override formoonshotai/kimi-k2.This description was created by
for a324a9d. You can customize this summary. It will automatically update as commits are pushed.