fix: prevent unnecessary MCP server refresh on settings save #6773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add state comparison before triggering MCP refresh - Only call handleMcpEnabledChange when mcpEnabled value actually changes - Fixes issue where saving any settings triggers MCP refresh notifications Fixes #6772
dosubot
bot
added
size:S
5 tasks
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| } | ||
| } else { | ||
| // Just update the state without triggering refresh | ||
| await updateGlobalState("mcpEnabled", mcpEnabled) |
Contributor
Author
There was a problem hiding this comment.
Is this redundant state update intentional? Since the value hasn't changed, calling updateGlobalState("mcpEnabled", mcpEnabled) seems unnecessary. Could we simply skip this update entirely when the value is unchanged?
| if (mcpHubInstance) { | ||
| await mcpHubInstance.handleMcpEnabledChange(mcpEnabled) | ||
| // Only update and refresh if the value actually changed | ||
| if (currentMcpEnabled !== mcpEnabled) { |
Contributor
Author
There was a problem hiding this comment.
Consider adding a comment here explaining why we check for value changes. Something like:
This would help future maintainers understand the performance optimization.
8 tasks
Member
|
Closing in favor of #6779 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where saving any settings in the Roo Code VS Code extension incorrectly triggers MCP server refresh notifications, even when the changed settings are unrelated to MCP functionality.
Problem
When users save settings via the sprocket icon, the system displays "All MCP servers have been refreshed" notifications regardless of what settings were changed. This creates a confusing user experience and triggers unnecessary server refresh operations.
Root Cause
The issue occurs because:
SettingsView.tsxalways sends themcpEnabledmessage when saving settingswebviewMessageHandler.tsunconditionally callshandleMcpEnabledChangewhen receiving the messageMcpHub.tsrefreshes all MCP connections without checking if the value actually changedSolution
Added a state comparison in
webviewMessageHandler.tsbefore triggering MCP refresh:mcpEnabledvalue with the current statehandleMcpEnabledChangewhen the value actually changesTesting
Acceptance Criteria
Fixes #6772
Important
Fixes unnecessary MCP server refresh notifications by adding state comparison for
mcpEnabledinwebviewMessageHandler.ts.webviewMessageHandler.ts.mcpEnabledto trigger refresh only on actual changes.mcpEnabledvalue with current state before callinghandleMcpEnabledChange.This description was created by
for beeb1a0. You can customize this summary. It will automatically update as commits are pushed.