Skip to content

feat: add optional todos parameter to new_task tool with experimental setting (#6329) #6775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 21, 2025
Merged

feat: add optional todos parameter to new_task tool with experimental setting (#6329) #6775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4bf0a43
feat: add optional todos parameter to new_task tool with experimental…
hannesrudolph Aug 6, 2025
c7fe8f7
fix: update new_task tool example to include todos parameter
hannesrudolph Aug 6, 2025
3e01630
fix: make new_task tool definition dynamic based on experimental setting
hannesrudolph Aug 6, 2025
de00926
fix: add translations for newTaskRequireTodos experimental setting
hannesrudolph Aug 6, 2025
7b9fce5
test: update snapshots for new_task tool example with todos parameter
hannesrudolph Aug 6, 2025
75f5e12
Update src/core/tools/newTaskTool.ts
hannesrudolph Aug 6, 2025
c8a4b50
fix: address PR review comments
Aug 19, 2025
ed0abcd
fix: revert order of operations in startTask to fix integration test …
hannesrudolph Aug 7, 2025
f7012c7
fix: hide todos parameter from new_task tool prompt when experiment i…
roomote Aug 7, 2025
e9da4b9
fix: update snapshots for new_task tool todos parameter
roomote Aug 7, 2025
bbf71de
feat: move newTaskRequireTodos from experimental to VSCode settings
Aug 20, 2025
1781044
fix: make new_task tool description dynamically reflect VSCode setting
Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/types/src/experiment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@ import type { Keys, Equals, AssertEqual } from "./type-fu.js"
* ExperimentId
*/

export const experimentIds = ["powerSteering", "multiFileApplyDiff", "preventFocusDisruption", "assistantMessageParser"] as const
export const experimentIds = [
"powerSteering",
"multiFileApplyDiff",
"preventFocusDisruption",
"assistantMessageParser",
] as const

export const experimentIdsSchema = z.enum(experimentIds)

Expand Down
6 changes: 6 additions & 0 deletions src/core/prompts/__tests__/__snapshots__/add-custom-instructions/architect-mode-prompt.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/core/prompts/__tests__/__snapshots__/add-custom-instructions/ask-mode-prompt.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions ...prompts/__tests__/__snapshots__/add-custom-instructions/mcp-server-creation-disabled.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .../prompts/__tests__/__snapshots__/add-custom-instructions/mcp-server-creation-enabled.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/core/prompts/__tests__/__snapshots__/add-custom-instructions/partial-reads-enabled.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/core/prompts/__tests__/__snapshots__/system-prompt/consistent-system-prompt.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/core/prompts/__tests__/__snapshots__/system-prompt/with-computer-use-support.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/core/prompts/__tests__/__snapshots__/system-prompt/with-diff-enabled-false.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/core/prompts/__tests__/__snapshots__/system-prompt/with-diff-enabled-true.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/core/prompts/__tests__/__snapshots__/system-prompt/with-diff-enabled-undefined.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/core/prompts/__tests__/__snapshots__/system-prompt/with-different-viewport-size.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/core/prompts/__tests__/__snapshots__/system-prompt/with-mcp-hub-provided.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/core/prompts/__tests__/__snapshots__/system-prompt/with-undefined-mcp-hub.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/core/prompts/__tests__/system-prompt.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,7 @@ describe("SYSTEM_PROMPT", () => {
maxConcurrentFileReads: 5,
todoListEnabled: false,
useAgentRules: true,
newTaskRequireTodos: false,
}

const prompt = await SYSTEM_PROMPT(
Expand Down Expand Up @@ -612,6 +613,7 @@ describe("SYSTEM_PROMPT", () => {
maxConcurrentFileReads: 5,
todoListEnabled: true,
useAgentRules: true,
newTaskRequireTodos: false,
}

const prompt = await SYSTEM_PROMPT(
Expand Down Expand Up @@ -643,6 +645,7 @@ describe("SYSTEM_PROMPT", () => {
maxConcurrentFileReads: 5,
todoListEnabled: true,
useAgentRules: true,
newTaskRequireTodos: false,
}

const prompt = await SYSTEM_PROMPT(
Expand Down
72 changes: 64 additions & 8 deletions src/core/prompts/sections/__tests__/custom-instructions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,14 @@ describe("addCustomInstructions", () => {
"global instructions",
"/fake/path",
"test-mode",
{ settings: { maxConcurrentFileReads: 5, todoListEnabled: true, useAgentRules: true } },
{
settings: {
maxConcurrentFileReads: 5,
todoListEnabled: true,
useAgentRules: true,
newTaskRequireTodos: false,
},
},
)

expect(result).toContain("# Agent Rules Standard (AGENTS.md):")
Expand All @@ -560,7 +567,14 @@ describe("addCustomInstructions", () => {
"global instructions",
"/fake/path",
"test-mode",
{ settings: { maxConcurrentFileReads: 5, todoListEnabled: true, useAgentRules: false } },
{
settings: {
maxConcurrentFileReads: 5,
todoListEnabled: true,
useAgentRules: false,
newTaskRequireTodos: false,
},
},
)

expect(result).not.toContain("# Agent Rules Standard (AGENTS.md):")
Expand Down Expand Up @@ -614,7 +628,14 @@ describe("addCustomInstructions", () => {
"global instructions",
"/fake/path",
"test-mode",
{ settings: { maxConcurrentFileReads: 5, todoListEnabled: true, useAgentRules: true } },
{
settings: {
maxConcurrentFileReads: 5,
todoListEnabled: true,
useAgentRules: true,
newTaskRequireTodos: false,
},
},
)

expect(result).toContain("Global Instructions:\nglobal instructions")
Expand Down Expand Up @@ -653,7 +674,14 @@ describe("addCustomInstructions", () => {
"global instructions",
"/fake/path",
"test-mode",
{ settings: { maxConcurrentFileReads: 5, todoListEnabled: true, useAgentRules: true } },
{
settings: {
maxConcurrentFileReads: 5,
todoListEnabled: true,
useAgentRules: true,
newTaskRequireTodos: false,
},
},
)

// Should contain both AGENTS.md and .roorules content
Expand Down Expand Up @@ -714,7 +742,14 @@ describe("addCustomInstructions", () => {
"global instructions",
"/fake/path",
"test-mode",
{ settings: { maxConcurrentFileReads: 5, todoListEnabled: true, useAgentRules: true } },
{
settings: {
maxConcurrentFileReads: 5,
todoListEnabled: true,
useAgentRules: true,
newTaskRequireTodos: false,
},
},
)

expect(result).toContain("# Agent Rules Standard (AGENTS.md):")
Expand Down Expand Up @@ -759,7 +794,14 @@ describe("addCustomInstructions", () => {
"global instructions",
"/fake/path",
"test-mode",
{ settings: { maxConcurrentFileReads: 5, todoListEnabled: true, useAgentRules: true } },
{
settings: {
maxConcurrentFileReads: 5,
todoListEnabled: true,
useAgentRules: true,
newTaskRequireTodos: false,
},
},
)

expect(result).toContain("# Agent Rules Standard (AGENTS.md):")
Expand Down Expand Up @@ -806,7 +848,14 @@ describe("addCustomInstructions", () => {
"global instructions",
"/fake/path",
"test-mode",
{ settings: { maxConcurrentFileReads: 5, todoListEnabled: true, useAgentRules: true } },
{
settings: {
maxConcurrentFileReads: 5,
todoListEnabled: true,
useAgentRules: true,
newTaskRequireTodos: false,
},
},
)

expect(result).toContain("# Agent Rules Standard (AGENT.md):")
Expand Down Expand Up @@ -845,7 +894,14 @@ describe("addCustomInstructions", () => {
"global instructions",
"/fake/path",
"test-mode",
{ settings: { maxConcurrentFileReads: 5, todoListEnabled: true, useAgentRules: true } },
{
settings: {
maxConcurrentFileReads: 5,
todoListEnabled: true,
useAgentRules: true,
newTaskRequireTodos: false,
},
},
)

// Should contain AGENTS.md content (preferred) and not AGENT.md
Expand Down
6 changes: 6 additions & 0 deletions src/core/prompts/sections/tool-use.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ For example, to use the new_task tool:
<new_task>
<mode>code</mode>
<message>Implement a new feature for the application.</message>
<todos>
[ ] Design the feature architecture
[ ] Implement core functionality
[ ] Add error handling
[ ] Write tests
</todos>
</new_task>

Always use the actual tool name as the XML tag name for proper parsing and execution.`
Expand Down
Loading
Loading