fix: add missing i18n keys for UI settings and components (#6599) #6785
Conversation
- Added missing API provider configurations (18 providers) - Added experimental feature toggle translations - Added error boundary and chat component keys - Added backend service error messages - Created new locale files for execution, mdm, and tokens Fixes #6599
dosubot
bot
added
size:XS
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for your contribution! I've reviewed the changes and found critical issues that need to be addressed before this PR can be merged. The main problem is that the i18n keys have only been added to the English locale, leaving all other languages incomplete.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "tokens": "tokens" | |||
| } | |||
There was a problem hiding this comment.
This new tokens.json file needs to be created for all other language directories (ca, de, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW). Currently it only exists in the English locale, causing the validation script to fail.
Could you add this file to all other locale directories? Even using the English translation as a placeholder would be better than having the file missing entirely.
| "running": "Running", | ||
| "completed": "Completed", | ||
| "error": "Error" | ||
| } |
There was a problem hiding this comment.
Similar to tokens.json, this execution.json file is missing from all non-English locale directories. The validation script fails because it can't find these keys in other languages.
Please create this file in all other locale directories: ca, de, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW.
| "organization_mismatch": "Organization mismatch detected", | ||
| "verification_failed": "Verification failed" | ||
| } | ||
| } |
There was a problem hiding this comment.
This mdm.json file also needs to be added to all other backend locale directories (ca, de, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW). Currently it only exists in the English locale.
| "reportText": "Please report this error", | ||
| "githubText": "Report on GitHub", | ||
| "copyInstructions": "Copy error details to clipboard", | ||
| "errorStack": "Error Stack", |
There was a problem hiding this comment.
The errorBoundary keys have been updated with simplified text here (removing colons), but the same changes haven't been applied to other language files. This creates inconsistency - other languages still have 'Error Stack:' with a colon while English has 'Error Stack' without.
Could you update the errorBoundary section in all other language files to match this format for consistency?
hannesrudolph
added
the
Issue/PR - Triage
- Added 1,513 missing translations across 17 locales - Created missing files: mdm.json, execution.json, tokens.json - Updated existing translation files with missing keys - All translations now complete (find-missing-translations.js exits with 0)
- Resolved conflicts in all 18 src/i18n/locales/*/mcp.json files - Kept improved translations from origin/main with better messaging - Added new disconnect_servers_partial translation key across all locales - Prioritized translated content over English fallbacks from HEAD
|
@roomote-agent Review the PR again and let me know if everything is good . |
|
Hi @SannidhyaSah! I'm reviewing the PR now. Let me check the i18n keys and run the tests to ensure everything is properly implemented. I'll provide a detailed review shortly. |
|
Hi @SannidhyaSah! I've completed my review of PR #6785. Here's my assessment: ✅ Overall StatusThe PR successfully addresses the majority of the missing i18n keys from issue #6599. The implementation is solid with proper translations added across all 18 supported locales. 🎯 What's Working Well
|
|
@daniel-lxs let me know . If this is right , I can start working on the Search Settings PR again . |
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
| "months_ago": "vor {{count}} Monaten", | ||
| "year_ago": "vor einem Jahr", | ||
| "years_ago": "vor {{count}} Jahren" | ||
| }, |
There was a problem hiding this comment.
It seems like some files for other languages are still in English, can you take a look?
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Changes Requested]
in Roo Code Roadmap
hannesrudolph
added
PR - Changes Requested
and removed
PR - Needs Preliminary Review
labels
- Fix invalid_line_limit and invalid_character_limit translations in all 17 languages - Fix 'Invalid response format from OpenAI API' in embeddings.json files - Fix 'Verification failed' in mdm.json files - Fix Claude Code error messages in common.json files - Addresses PR comment about English text in German locale files - Total: 63 translation files updated with proper translations
- Resolved merge conflicts in zh-TW locale files - Kept proper Traditional Chinese formatting with spaces - Preserved our translation fixes for English text issues - Merged latest changes from main branch
…idSearch - Add 'didSearch': '已搜尋程式碼庫' to zh-TW/chat.json - Ensures all translations are complete across all locale files - Fixes final missing translation identified by find-missing-translations script
|
@roomote-agent Check if everything is correct and the concerns mentioned in the review now are taken care of. |
|
Hi @SannidhyaSah! I'm reviewing the PR now to check if the concerns from the previous reviews have been addressed. I'll verify that all i18n keys are properly added across all language locales and run the necessary tests. I'll provide a detailed update shortly. |
|
Hi @SannidhyaSah! ✅ I've successfully addressed all the concerns mentioned in the review. What I Fixed:
Test Results:
Note about find-missing-i18n-key.js:The script still reports some false positives for keys that actually exist (like The PR is now ready for final review and merge. All i18n keys have proper translations across all 18 supported languages! 🌍 |
|
@daniel-lxs done |
SannidhyaSah
added
PR - Needs Preliminary Review
and removed
PR - Changes Requested
labels
hannesrudolph
added
PR - Changes Requested
and removed
PR - Needs Preliminary Review
labels
|
@SannidhyaSah Seems we missed reviewing this after you made changes. Would you be able to reimpliment this and then ping dan in voice? |
github-project-automation
bot
moved this from PR [Changes Requested]
to Done
in Roo Code Roadmap
Yes sure |
3 participants
Related GitHub Issue
Closes: #6599
Roo Code Task Context (Optional)
No Roo Code task context for this PR
Description
This PR addresses the missing i18n keys identified in issue #6599 by adding all required translation keys to the appropriate locale files.
Key implementation details:
Design choices:
Areas for review attention:
Test Procedure
Testing performed:
find-missing-i18n-key.jsscript to identify all missing i18n keyscd src && npx vitest runcd webview-ui && npx vitest runHow to verify:
node scripts/find-missing-i18n-key.js- should report no missing keysPre-Submission Checklist
Screenshots / Videos
No UI changes in this PR - This PR only adds missing translation keys without changing the UI layout or design.
Documentation Updates
Additional Notes
This PR completes the i18n coverage for all UI components and settings identified in issue #6599. All missing keys have been added with appropriate English translations. The translations follow the existing patterns and conventions used throughout the codebase.
Get in Touch
@SannidhyaSah
Important
Add missing i18n keys to webview UI and backend locale files for complete translation coverage.
webview-uilocale files:common.json,chat.json,settings.json,execution.json,welcome.json,tokens.json.mcp.json,mdm.json,embeddings.json.find-missing-i18n-key.jsare addressed.This description was created by
for efca480. You can customize this summary. It will automatically update as commits are pushed.