fix: remove shift key requirement for image drag-and-drop #6957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6953 - Users can now drag and drop images into the prompt field without holding the Shift key. This restores the expected behavior where drag-and-drop works naturally for image files.
dosubot
bot
added
size:XS
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| return | ||
| } | ||
|
|
||
| e.preventDefault() |
Contributor
Author
There was a problem hiding this comment.
Good fix! This removes the unnecessary shift key requirement that was blocking normal drag-and-drop behavior. However, was this shift key check originally added for a specific UX reason (e.g., to prevent accidental drops)? If so, we might want to document why we're removing it now.
|
|
||
| e.preventDefault() | ||
| setIsDraggingOver(true) | ||
| e.dataTransfer.dropEffect = "copy" |
Contributor
Author
There was a problem hiding this comment.
Consider adding tests for drag-and-drop functionality to prevent regression. While the PR mentions tests pass, I don't see specific tests covering this drag-and-drop behavior.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6953
This PR removes the shift key requirement that was preventing users from dragging and dropping images into the Roo Code prompt field.
The issue was caused by a check in the onDragOver event handler that required the Shift key to be held. This has been removed to restore the expected drag-and-drop behavior.
All tests pass and the functionality now works as expected.
Important
Removes shift key requirement for drag-and-drop in
ChatTextArea.tsx, allowing image/file drops without it.onDragOverevent handler inChatTextArea.tsx.This description was created by
for 0bb89a5. You can customize this summary. It will automatically update as commits are pushed.